Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2351113005: [Reland] Refactor WebappRegistry into a singleton instance. (Closed)
Patch Set: Comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index 4e2e9fe048e478ff1a4d4f18b9e2d6c360234fd7..f008b182f68e728e20869ff84e66a1d070ec6b7b 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -128,7 +128,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
}
private static class TestDataStorageFactory extends WebappDataStorage.Factory {
- public Bitmap mSplashImage;
+ public String mSplashImage;
@Override
public WebappDataStorage create(final String webappId) {
@@ -142,7 +142,7 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
}
@Override
- public void updateSplashScreenImage(Bitmap splashScreenImage) {
+ public void updateSplashScreenImage(String splashScreenImage) {
assertNull(mSplashImage);
mSplashImage = splashScreenImage;
}
@@ -539,7 +539,8 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
// Test that bitmap sizes match expectations.
int idealSize = getActivity().getResources().getDimensionPixelSize(
R.dimen.webapp_splash_image_size_ideal);
- assertEquals(idealSize, dataStorageFactory.mSplashImage.getWidth());
- assertEquals(idealSize, dataStorageFactory.mSplashImage.getHeight());
+ Bitmap splashImage = ShortcutHelper.decodeBitmapFromString(dataStorageFactory.mSplashImage);
+ assertEquals(idealSize, splashImage.getWidth());
+ assertEquals(idealSize, splashImage.getHeight());
}
}

Powered by Google App Engine
This is Rietveld 408576698