[Reland] Refactor WebappRegistry into a singleton instance.

chrome/android/java/src/org/chromium/chrome/browser/ServiceTabLauncher.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.content.Context;
 import android.content.Intent;
 import android.os.AsyncTask;
 
 import org.chromium.base.CommandLine;
 import org.chromium.base.annotations.CalledByNative;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;
 import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParams;
 import org.chromium.chrome.browser.tabmodel.document.TabDelegate;
 import org.chromium.chrome.browser.webapps.WebappDataStorage;
 import org.chromium.chrome.browser.webapps.WebappRegistry;
-import org.chromium.chrome.browser.webapps.WebappRegistry.FetchWebappDataStorageCallback;
 import org.chromium.content_public.browser.LoadUrlParams;
 import org.chromium.content_public.browser.WebContents;
 import org.chromium.content_public.common.Referrer;
 import org.chromium.content_public.common.ResourceRequestBody;
 import org.chromium.ui.base.PageTransition;
 import org.chromium.webapk.lib.client.WebApkNavigationClient;
 import org.chromium.webapk.lib.client.WebApkValidator;
 
 /**
  * Tab Launcher to be used to launch new tabs from background Android Services,
@@ skipping 37 matching lines @@
                 if (intent != null) {
                     intent.putExtra(ShortcutHelper.EXTRA_SOURCE, ShortcutSource.NOTIFICATION);
                     context.startActivity(intent);
                     return;
                 }
             }
         }
 
         // 2. Launch WebappActivity if one matches the target URL and was opened recently.
         // Otherwise, open the URL in a tab.
-        FetchWebappDataStorageCallback callback = new FetchWebappDataStorageCallback() {
-            @Override
-            public void onWebappDataStorageRetrieved(final WebappDataStorage storage) {
-                // If we do not find a WebappDataStorage corresponding to this URL, or if it hasn't
-                // been opened recently enough, open the URL in a tab.
-                if (storage == null || !storage.wasLaunchedRecently()) {
-                    LoadUrlParams loadUrlParams = new LoadUrlParams(url, PageTransition.LINK);
-                    loadUrlParams.setPostData(postData);
-                    loadUrlParams.setVerbatimHeaders(extraHeaders);
-                    loadUrlParams.setReferrer(new Referrer(referrerUrl, referrerPolicy));
+        final WebappDataStorage storage =
+                WebappRegistry.getInstance().getWebappDataStorageForUrl(url);
 
-                    AsyncTabCreationParams asyncParams = new AsyncTabCreationParams(loadUrlParams,
-                            requestId);
-                    tabDelegate.createNewTab(asyncParams, TabLaunchType.FROM_CHROME_UI,
-                            Tab.INVALID_TAB_ID);
-                } else {
-                    // The URL is within the scope of a recently launched standalone-capable web app
-                    // on the home screen, so open it a standalone web app frame. An AsyncTask is
-                    // used because WebappDataStorage.createWebappLaunchIntent contains a Bitmap
-                    // decode operation and should not be run on the UI thread.
-                    //
-                    // This currently assumes that the only source is notifications; any future use
-                    // which adds a different source will need to change this.
-                    new AsyncTask<Void, Void, Intent>() {
-                        @Override
-                        protected final Intent doInBackground(Void... nothing) {
-                            return storage.createWebappLaunchIntent();
-                        }
+        // If we do not find a WebappDataStorage corresponding to this URL, or if it hasn't
+        // been opened recently enough, open the URL in a tab.
+        if (storage == null || !storage.wasLaunchedRecently()) {
+            LoadUrlParams loadUrlParams = new LoadUrlParams(url, PageTransition.LINK);
+            loadUrlParams.setPostData(postData);
+            loadUrlParams.setVerbatimHeaders(extraHeaders);
+            loadUrlParams.setReferrer(new Referrer(referrerUrl, referrerPolicy));
 
-                        @Override
-                        protected final void onPostExecute(Intent intent) {
-                            // Replace the web app URL with the URL from the notification. This is
-                            // within the webapp's scope, so it is valid.
-                            intent.putExtra(ShortcutHelper.EXTRA_URL, url);
-                            intent.putExtra(ShortcutHelper.EXTRA_SOURCE,
-                                    ShortcutSource.NOTIFICATION);
-                            tabDelegate.createNewStandaloneFrame(intent);
-                        }
-                    }.execute();
+            AsyncTabCreationParams asyncParams = new AsyncTabCreationParams(loadUrlParams,
+                    requestId);
+            tabDelegate.createNewTab(asyncParams, TabLaunchType.FROM_CHROME_UI,
+                    Tab.INVALID_TAB_ID);
+        } else {
+            // The URL is within the scope of a recently launched standalone-capable web app
+            // on the home screen, so open it a standalone web app frame. An AsyncTask is
+            // used because WebappDataStorage.createWebappLaunchIntent contains a Bitmap
+            // decode operation and should not be run on the UI thread.
+            //
+            // This currently assumes that the only source is notifications; any future use
+            // which adds a different source will need to change this.
+            new AsyncTask<Void, Void, Intent>() {
+                @Override
+                protected final Intent doInBackground(Void... nothing) {
+                    return storage.createWebappLaunchIntent();
                 }
-            }
-        };
-        WebappRegistry.getWebappDataStorageForUrl(url, callback);
+
+                @Override
+                protected final void onPostExecute(Intent intent) {
+                    // Replace the web app URL with the URL from the notification. This is
+                    // within the webapp's scope, so it is valid.
+                    intent.putExtra(ShortcutHelper.EXTRA_URL, url);
+                    intent.putExtra(ShortcutHelper.EXTRA_SOURCE,
+                            ShortcutSource.NOTIFICATION);
+                    tabDelegate.createNewStandaloneFrame(intent);
+                }
+            }.executeOnExecutor(AsyncTask.THREAD_POOL_EXECUTOR);
+        }
     }
 
     /**
      * To be called by the activity when the WebContents for |requestId| has been created, or has
      * been recycled from previous use. The |webContents| must not yet have started provisional
      * load for the main frame.
      *
      * @param requestId Id of the tab launching request which has been fulfilled.
      * @param webContents The WebContents instance associated with this request.
      */
     public static void onWebContentsForRequestAvailable(int requestId, WebContents webContents) {
         nativeOnWebContentsForRequestAvailable(requestId, webContents);
     }
 
     private static native void nativeOnWebContentsForRequestAvailable(
             int requestId, WebContents webContents);
 }