[modules] Expand API to allow linking and use it in d8

[modules] Expand API to allow linking and use it in d8

This patch gives the ability for the embedder to ask for the
module requests of a module, and to pass a ResolveCallback
into Module::Instantiate().

In d8, I've implemented a simple module_map that's used
along with this API to allow loading, compiling, instantiating,
and evaluating a whole tree of modules.

No path resolution is yet implemented, meaning that all
import paths are relative to whatever directory d8 runs
in. And no imports are linked to the exports of the
requested module.

BUG=v8:1569
Committed: https://crrev.com/cf127e81449f0bc4d09368a376623fe3743094a7
Cr-Commit-Position: refs/heads/master@{#39569}

[adamk, 2016-09-20 19:07:12]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 19:07:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 19:37:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 19:37:54]

Dry run: This issue passed the CQ dry run.

[adamk, 2016-09-20 20:36:17]

Description was changed from

==========
[modules] Work in progress: teach d8 to load imported modules

BUG=v8:1569
==========

to

==========
[modules] Expand API to allow linking and use it in d8

This patch gives the ability for the embedder to ask for the
module requests of a module, and to pass a ResolveCallback
into Module::Instantiate().

In d8, I've implemented a simple module_map that's used
along with this API to allow loading, compiling, instantiating,
and evaluating a whole tree of modules.

No path resolution is yet implemented, meaning that all
import paths are relative to whatever directory d8 runs
in. And no imports are linked to the exports of the
requested module.

BUG=v8:1569
==========

[adamk, 2016-09-20 20:36:39]

adamk@chromium.org changed reviewers:
+ neis@chromium.org

[neis, 2016-09-20 21:07:30]

lgtm with minor comments

https://codereview.chromium.org/2351113004/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2351113004/diff/40001/include/v8.h#newcode1083
include/v8.h:1083: */
s/imported/requested/, or say "imported or re-exported [from]"

https://codereview.chromium.org/2351113004/diff/40001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2351113004/diff/40001/src/api.cc#newcode1986
src/api.cc:1986: i::Handle<i::Object> receiver =
isolate->factory()->undefined_value();
Why did this move here?

https://codereview.chromium.org/2351113004/diff/40001/src/api.cc#newcode1990
src/api.cc:1990: int requested_modules_length = requested_modules->length();
Please move length into the for, like above.

https://codereview.chromium.org/2351113004/diff/40001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2351113004/diff/40001/src/d8.cc#newcode535
src/d8.cc:535: int num_imports = module->GetModuleRequestsLength();
Please rename to length and move into the for.

https://codereview.chromium.org/2351113004/diff/40001/src/d8.cc#newcode537
src/d8.cc:537: Local<String> import_name = module->GetModuleRequest(i);
Please rename to name.

https://codereview.chromium.org/2351113004/diff/40001/src/d8.cc#newcode594
src/d8.cc:594: data->realm_current_ = data->realm_switch_;
Please remove this if possible.

[adamk, 2016-09-20 21:13:58]

https://codereview.chromium.org/2351113004/diff/40001/include/v8.h
File include/v8.h (right):

https://codereview.chromium.org/2351113004/diff/40001/include/v8.h#newcode1083
include/v8.h:1083: */
On 2016/09/20 21:07:30, neis wrote:
> s/imported/requested/, or say "imported or re-exported [from]"

Done.

https://codereview.chromium.org/2351113004/diff/40001/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2351113004/diff/40001/src/api.cc#newcode1986
src/api.cc:1986: i::Handle<i::Object> receiver =
isolate->factory()->undefined_value();
On 2016/09/20 21:07:30, neis wrote:
> Why did this move here?

No reason, moved back.

https://codereview.chromium.org/2351113004/diff/40001/src/api.cc#newcode1990
src/api.cc:1990: int requested_modules_length = requested_modules->length();
On 2016/09/20 21:07:30, neis wrote:
> Please move length into the for, like above.

Done.

https://codereview.chromium.org/2351113004/diff/40001/src/d8.cc
File src/d8.cc (right):

https://codereview.chromium.org/2351113004/diff/40001/src/d8.cc#newcode535
src/d8.cc:535: int num_imports = module->GetModuleRequestsLength();
On 2016/09/20 21:07:30, neis wrote:
> Please rename to length and move into the for.

Done.

https://codereview.chromium.org/2351113004/diff/40001/src/d8.cc#newcode537
src/d8.cc:537: Local<String> import_name = module->GetModuleRequest(i);
On 2016/09/20 21:07:30, neis wrote:
> Please rename to name.

Done.

https://codereview.chromium.org/2351113004/diff/40001/src/d8.cc#newcode594
src/d8.cc:594: data->realm_current_ = data->realm_switch_;
On 2016/09/20 21:07:30, neis wrote:
> Please remove this if possible.

Removed this. I'm still using the current realm to figure out the
context to use, but that seems fine.

Realm.switch is only used for interactive use cases, and we'll probably need a
whole lot of support here to figure out how to use modules interactively.

[adamk, 2016-09-20 22:35:05]

Added a few cctests, one of which covers one case that d8 doesn't hit.

[adamk, 2016-09-20 22:35:09]

The CQ bit was checked by adamk@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 22:35:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 22:43:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 22:43:07]

Dry run: Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)

[adamk, 2016-09-20 22:57:50]

The CQ bit was checked by adamk@chromium.org

[adamk, 2016-09-20 22:57:50]

The patchset sent to the CQ was uploaded after l-g-t-m from neis@chromium.org
Link to the patchset: https://codereview.chromium.org/2351113004/#ps100001
(title: "Use StrictEquals, remove check for bad instantiation behavior")

[commit-bot: I haz the power, 2016-09-20 22:57:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 23:39:05]

Description was changed from

==========
[modules] Expand API to allow linking and use it in d8

This patch gives the ability for the embedder to ask for the
module requests of a module, and to pass a ResolveCallback
into Module::Instantiate().

In d8, I've implemented a simple module_map that's used
along with this API to allow loading, compiling, instantiating,
and evaluating a whole tree of modules.

No path resolution is yet implemented, meaning that all
import paths are relative to whatever directory d8 runs
in. And no imports are linked to the exports of the
requested module.

BUG=v8:1569
==========

to

==========
[modules] Expand API to allow linking and use it in d8

This patch gives the ability for the embedder to ask for the
module requests of a module, and to pass a ResolveCallback
into Module::Instantiate().

In d8, I've implemented a simple module_map that's used
along with this API to allow loading, compiling, instantiating,
and evaluating a whole tree of modules.

No path resolution is yet implemented, meaning that all
import paths are relative to whatever directory d8 runs
in. And no imports are linked to the exports of the
requested module.

BUG=v8:1569
==========

[commit-bot: I haz the power, 2016-09-20 23:39:06]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-20 23:39:51]

Description was changed from

==========
[modules] Expand API to allow linking and use it in d8

This patch gives the ability for the embedder to ask for the
module requests of a module, and to pass a ResolveCallback
into Module::Instantiate().

In d8, I've implemented a simple module_map that's used
along with this API to allow loading, compiling, instantiating,
and evaluating a whole tree of modules.

No path resolution is yet implemented, meaning that all
import paths are relative to whatever directory d8 runs
in. And no imports are linked to the exports of the
requested module.

BUG=v8:1569
==========

to

==========
[modules] Expand API to allow linking and use it in d8

This patch gives the ability for the embedder to ask for the
module requests of a module, and to pass a ResolveCallback
into Module::Instantiate().

In d8, I've implemented a simple module_map that's used
along with this API to allow loading, compiling, instantiating,
and evaluating a whole tree of modules.

No path resolution is yet implemented, meaning that all
import paths are relative to whatever directory d8 runs
in. And no imports are linked to the exports of the
requested module.

BUG=v8:1569

Committed: https://crrev.com/cf127e81449f0bc4d09368a376623fe3743094a7
Cr-Commit-Position: refs/heads/master@{#39569}
==========

[commit-bot: I haz the power, 2016-09-20 23:39:52]

Patchset 6 (id:??) landed as
https://crrev.com/cf127e81449f0bc4d09368a376623fe3743094a7
Cr-Commit-Position: refs/heads/master@{#39569}