Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Issue 23511012: Update histogram names for WebFont usage metrics (Closed)

Created:
7 years, 3 months ago by Kunihiko Sakamoto
Modified:
7 years, 3 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, Ilya Sherman, jar (doing other things), asvitkine+watch_chromium.org
Visibility:
Public.

Description

Update histogram names for WebFont usage metrics Changing the histogram names since the definition of the histogram changed in https://codereview.chromium.org/23720005 BUG=246492 NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221352

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 2 chunks +29 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kunihiko Sakamoto
7 years, 3 months ago (2013-09-05 05:15:39 UTC) #1
Ilya Sherman
histograms.xml lgtm https://codereview.chromium.org/23511012/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/23511012/diff/1/tools/metrics/histograms/histograms.xml#newcode17748 tools/metrics/histograms/histograms.xml:17748: + each FontResource object on the renderer's ...
7 years, 3 months ago (2013-09-05 05:34:52 UTC) #2
Kunihiko Sakamoto
Thanks. https://codereview.chromium.org/23511012/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/23511012/diff/1/tools/metrics/histograms/histograms.xml#newcode17748 tools/metrics/histograms/histograms.xml:17748: + each FontResource object on the renderer's memory ...
7 years, 3 months ago (2013-09-05 05:38:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ksakamoto@chromium.org/23511012/5001
7 years, 3 months ago (2013-09-05 05:39:18 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-05 06:42:33 UTC) #5
Message was sent while issue was closed.
Change committed as 221352

Powered by Google App Engine
This is Rietveld 408576698