LayoutTests/css3/compositing/mix-blend-mode-isolation-layer.html - Issue 23511004: mix-blend-mode implementation for accelerated layers - blink part

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/css3/compositing/mix-blend-mode-isolation-layer.html

Issue 23511004: mix-blend-mode implementation for accelerated layers - blink part (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Renamed a variable Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script>

	4 if (window.testRunner) {

	5 testRunner.dumpAsText();

	6 window.addEventListener('load', function () {

	7 document.getElementById('layers').textContent = window.internals.layerTree AsText(document);

	8 document.getElementById('stacking-context').style.display = 'none';

	9 }, false);

	10 }

	11 </script>

	12 <style>

	13 #stacking-context,

	14 .accelerated {

	15 -webkit-transform: rotateX(0deg);

	16 }

	17 .blended {

	18 mix-blend-mode: multiply;

	19 }

	20 </style>

	21 </head>

	22 <body>

	23 <div id="stacking-context">
	enne (OOO) 2013/11/11 21:52:46 Can you add another test with an additional stacki Can you add another test with an additional stacking context parent to verify that it does not get (isolate 1) in its layer tree dump? I think your code does the right thing, but I'd like to regression test that. (This is where RenderLayerCompositor could really use a unit test framework.) Also, can you add a test that has a tree like: Stacking context A (composited) Stacking context B (not composited) Blending element C To verify that neither B nor C get composited for blending or isolate reasons? rosca 2013/11/12 20:27:07 Done for the two tests you suggested. I added one Show quoted text On 2013/11/11 21:52:46, enne wrote: > Can you add another test with an additional stacking context parent to verify > that it does not get (isolate 1) in its layer tree dump? I think your code does > the right thing, but I'd like to regression test that. (This is where > RenderLayerCompositor could really use a unit test framework.) > > Also, can you add a test that has a tree like: > > Stacking context A (composited) > Stacking context B (not composited) > Blending element C > > To verify that neither B nor C get composited for blending or isolate reasons? Done for the two tests you suggested. I added one more test with a tree like: Stacking context A (not composited) Stacking context B (not composited) Blending element C (not composited) Composited element D It will verify that B and C will be accelerated and A will not.
	24 <img class="accelerated blended" src="resources/reference.png">

	25 </div>

	26 <pre id="layers">Layer tree goes here when testing</pre>

	27 </body>

	28 </html>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/css3/compositing/mix-blend-mode-isolation-layer-expected.txt » ('j') | Source/core/rendering/RenderLayerCompositor.cpp » ('J')