Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Side by Side Diff: gpu/command_buffer/service/framebuffer_manager.h

Issue 2351093002: Fix crash in BlitFramebufferCHROMIUM if a read or draw depth/stencil buffer is not present (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_ 5 #ifndef GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_
6 #define GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_ 6 #define GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 133 matching lines...) Expand 10 before | Expand all | Expand 10 after
144 has_been_bound_ = true; 144 has_been_bound_ = true;
145 } 145 }
146 146
147 bool IsValid() const { 147 bool IsValid() const {
148 return has_been_bound_ && !IsDeleted(); 148 return has_been_bound_ && !IsDeleted();
149 } 149 }
150 150
151 bool HasColorAttachment(int index) const; 151 bool HasColorAttachment(int index) const;
152 bool HasDepthAttachment() const; 152 bool HasDepthAttachment() const;
153 bool HasStencilAttachment() const; 153 bool HasStencilAttachment() const;
154 // The following look at DEPTH_STENCIL_ATTACHMENT or
155 // DEPTH_ATTACHMENT/STENCIL_ATTACHMENT.
156 // TODO(piman): DEPTH_STENCIL_ATTACHMENT is not a real attachment point,
157 // except for WebGL1. Fix this. http://crbug.com/630568
158 const Attachment* GetDepthAttachment() const;
159 const Attachment* GetStencilAttachment() const;
154 GLenum GetDepthFormat() const; 160 GLenum GetDepthFormat() const;
155 GLenum GetStencilFormat() const; 161 GLenum GetStencilFormat() const;
156 GLenum GetDrawBufferInternalFormat() const; 162 GLenum GetDrawBufferInternalFormat() const;
157 GLenum GetReadBufferInternalFormat() const; 163 GLenum GetReadBufferInternalFormat() const;
158 // If the color attachment is a texture, returns its type; otherwise, 164 // If the color attachment is a texture, returns its type; otherwise,
159 // returns 0. 165 // returns 0.
160 GLenum GetReadBufferTextureType() const; 166 GLenum GetReadBufferTextureType() const;
161 167
162 // Verify all the rules in OpenGL ES 2.0.25 4.4.5 are followed. 168 // Verify all the rules in OpenGL ES 2.0.25 4.4.5 are followed.
163 // Returns GL_FRAMEBUFFER_COMPLETE if there are no reasons we know we can't 169 // Returns GL_FRAMEBUFFER_COMPLETE if there are no reasons we know we can't
(...skipping 215 matching lines...) Expand 10 before | Expand all | Expand 10 after
379 385
380 scoped_refptr<FramebufferCompletenessCache> framebuffer_combo_complete_cache_; 386 scoped_refptr<FramebufferCompletenessCache> framebuffer_combo_complete_cache_;
381 387
382 DISALLOW_COPY_AND_ASSIGN(FramebufferManager); 388 DISALLOW_COPY_AND_ASSIGN(FramebufferManager);
383 }; 389 };
384 390
385 } // namespace gles2 391 } // namespace gles2
386 } // namespace gpu 392 } // namespace gpu
387 393
388 #endif // GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_ 394 #endif // GPU_COMMAND_BUFFER_SERVICE_FRAMEBUFFER_MANAGER_H_
OLDNEW
« no previous file with comments | « no previous file | gpu/command_buffer/service/framebuffer_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698