Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2351043002: Objects with a role of IA2_EMBEDDED_OBJECT should get a role of IA_SYSTEM_GROUPPING because otherwi… (Closed)

Created:
4 years, 3 months ago by nektarios
Modified:
4 years, 3 months ago
Reviewers:
dmazzoni
CC:
aboxhall+watch_chromium.org, chromium-reviews, darin-cc_chromium.org, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, jam, je_julie, nektar+watch_chromium.org, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Objects with a role of IA2_EMBEDDED_OBJECT should get a role of IA_SYSTEM_GROUPPING because otherwise Jaws and NVDA ignore any children. This makes the PDF viewer accessible on Windows with NVDA but not with Jaws. R=dmazzoni@chromium.org TESTED=manually with NVDA Committed: https://crrev.com/271cf4ef8d4200240486f0f55f74b71fd2f46a65 Cr-Commit-Position: refs/heads/master@{#419605}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/accessibility/browser_accessibility_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
nektarios
4 years, 3 months ago (2016-09-19 22:10:15 UTC) #1
nektarios
4 years, 3 months ago (2016-09-19 22:13:53 UTC) #2
dmazzoni
lgtm
4 years, 3 months ago (2016-09-19 23:13:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351043002/1
4 years, 3 months ago (2016-09-19 23:13:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 00:00:41 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 00:03:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/271cf4ef8d4200240486f0f55f74b71fd2f46a65
Cr-Commit-Position: refs/heads/master@{#419605}

Powered by Google App Engine
This is Rietveld 408576698