Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2351033004: Fix Win toolchain asset, fix script (Closed)

Created:
4 years, 3 months ago by borenet2
Modified:
4 years, 3 months ago
Reviewers:
herb_g, borenet, mtklein
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M infra/bots/assets/asset_utils.py View 1 2 chunks +6 lines, -1 line 0 comments Download
M infra/bots/assets/win_toolchain/VERSION View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
borenet
4 years, 3 months ago (2016-09-20 13:10:21 UTC) #3
mtklein
ah ha, lgtm
4 years, 3 months ago (2016-09-20 13:13:36 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351033004/20001
4 years, 3 months ago (2016-09-20 13:16:14 UTC) #7
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 14:01:26 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/f44b493cb8dbeb20763479bf30d025ede72032dc

Powered by Google App Engine
This is Rietveld 408576698