[CUPS] Add a "Manage..." button in the local destinations section of Print Preview Dialog on Chrome…

chrome/browser/resources/print_preview/search/destination_search.js

Index: chrome/browser/resources/print_preview/search/destination_search.js
diff --git a/chrome/browser/resources/print_preview/search/destination_search.js b/chrome/browser/resources/print_preview/search/destination_search.js
index f16cb101d6ddc672776b1ee04569712212193395..5484ac943f8b7b2fe513d6fa7093cafb3a8bbc58 100644
--- a/chrome/browser/resources/print_preview/search/destination_search.js
+++ b/chrome/browser/resources/print_preview/search/destination_search.js
@@ -98,7 +98,7 @@ cr.define('print_preview', function() {
     this.localList_ = new print_preview.DestinationList(
         this,
         loadTimeData.getString('localDestinationsTitle'),
-        cr.isChromeOS ? null : loadTimeData.getString('manage'));
+        loadTimeData.getString('manage'));
     this.addChild(this.localList_);
 
     /**
@@ -688,6 +688,10 @@ cr.define('print_preview', function() {
      * @private
      */
     onManageLocalDestinationsActivated_: function() {
+      if (cr.isChromeOS) {

[dpapad, 2016/09/19 22:21:19]

Is this the right place to intercept? How about adding this conditional logic
within the event handler of the event that is already dispatched below?


Also how is this working if chrome://md-settings is not enabled? AFAIK this is
still behind a feature flag, but the behavior here will change even for when the
feature flag is not enabled.

[xdai1, 2016/09/19 22:53:40]

Do you mean PrintPreview.onManageLocalDestinationsActivated_() in
print_preview.js or the webui handler function
PrintPreviewHandler::HandleManagePrinters() in print_preview_handler.cc?
The CUPS Printing is also behind a command flag (--enable-native-cups) and
currently is targeting M56. I guess the MD setting should have been launched by
that moment? If not, I will need check with the PM to see if there is any other
option for this issue.

[dpapad, 2016/09/20 00:03:23]

I meant the one in print_preview.js. It seems more appropriate to handle the
event there.

[xdai1, 2016/09/20 17:31:29]

Done.

+        window.open(loadTimeData.getString('localPrintersManagementURL'));
+        return;
+      }
       cr.dispatchSimpleEvent(
           this,
           print_preview.DestinationSearch.EventType.MANAGE_LOCAL_DESTINATIONS);