Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: chrome/browser/resources/print_preview/search/destination_search.js

Issue 2351023002: [CUPS] Add a "Manage..." button in the local destinations section of Print Preview Dialog on Chrome… (Closed)
Patch Set: Address dbeam@'s comments. Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('print_preview', function() { 5 cr.define('print_preview', function() {
6 'use strict'; 6 'use strict';
7 7
8 /** 8 /**
9 * Component used for searching for a print destination. 9 * Component used for searching for a print destination.
10 * This is a modal dialog that allows the user to search and select a 10 * This is a modal dialog that allows the user to search and select a
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 this.addChild(this.recentList_); 91 this.addChild(this.recentList_);
92 92
93 /** 93 /**
94 * Destination list containing local destinations. 94 * Destination list containing local destinations.
95 * @type {!print_preview.DestinationList} 95 * @type {!print_preview.DestinationList}
96 * @private 96 * @private
97 */ 97 */
98 this.localList_ = new print_preview.DestinationList( 98 this.localList_ = new print_preview.DestinationList(
99 this, 99 this,
100 loadTimeData.getString('localDestinationsTitle'), 100 loadTimeData.getString('localDestinationsTitle'),
101 cr.isChromeOS ? null : loadTimeData.getString('manage')); 101 cr.isChromeOS && loadTimeData.getBoolean('showLocalManageButton') ?
dpapad 2016/09/21 00:39:01 showLocalManageButton will be falsy if not in Chro
xdai1 2016/09/21 18:03:21 showLocalManageButton doesn't exist if not on Chro
dpapad 2016/09/21 18:13:47 See other related. Making it exist for non-ChromeO
xdai1 2016/09/21 18:36:14 Sorry I made a mistake here. We should always show
102 loadTimeData.getString('manage') : null);
102 this.addChild(this.localList_); 103 this.addChild(this.localList_);
103 104
104 /** 105 /**
105 * Destination list containing cloud destinations. 106 * Destination list containing cloud destinations.
106 * @type {!print_preview.DestinationList} 107 * @type {!print_preview.DestinationList}
107 * @private 108 * @private
108 */ 109 */
109 this.cloudList_ = new print_preview.CloudDestinationList(this); 110 this.cloudList_ = new print_preview.CloudDestinationList(this);
110 this.addChild(this.cloudList_); 111 this.addChild(this.cloudList_);
111 }; 112 };
(...skipping 651 matching lines...) Expand 10 before | Expand all | Expand 10 after
763 onWindowResize_: function() { 764 onWindowResize_: function() {
764 this.reflowLists_(); 765 this.reflowLists_();
765 } 766 }
766 }; 767 };
767 768
768 // Export 769 // Export
769 return { 770 return {
770 DestinationSearch: DestinationSearch 771 DestinationSearch: DestinationSearch
771 }; 772 };
772 }); 773 });
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698