[CUPS] Add a "Manage..." button in the local destinations section of Print Preview Dialog on Chrome…

chrome/browser/resources/print_preview/search/destination_search.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('print_preview', function() {
   'use strict';
 
   /**
    * Component used for searching for a print destination.
    * This is a modal dialog that allows the user to search and select a
@@ skipping 80 matching lines @@
     this.addChild(this.recentList_);
 
     /**
      * Destination list containing local destinations.
      * @type {!print_preview.DestinationList}
      * @private
      */
     this.localList_ = new print_preview.DestinationList(
         this,
         loadTimeData.getString('localDestinationsTitle'),
-        cr.isChromeOS ? null : loadTimeData.getString('manage'));
+        loadTimeData.getString('manage'));
     this.addChild(this.localList_);
 
     /**
      * Destination list containing cloud destinations.
      * @type {!print_preview.DestinationList}
      * @private
      */
     this.cloudList_ = new print_preview.CloudDestinationList(this);
     this.addChild(this.cloudList_);
   };
@@ skipping 569 matching lines @@
       cr.dispatchSimpleEvent(
           this,
           print_preview.DestinationSearch.EventType.MANAGE_CLOUD_DESTINATIONS);
     },
 
     /**
      * Called when the manage local printers action is activated.
      * @private
      */
     onManageLocalDestinationsActivated_: function() {
+      if (cr.isChromeOS) {

[dpapad, 2016/09/19 22:21:19]

Is this the right place to intercept? How about adding this conditional logic
within the event handler of the event that is already dispatched below?


Also how is this working if chrome://md-settings is not enabled? AFAIK this is
still behind a feature flag, but the behavior here will change even for when the
feature flag is not enabled.

[xdai1, 2016/09/19 22:53:40]

Do you mean PrintPreview.onManageLocalDestinationsActivated_() in
print_preview.js or the webui handler function
PrintPreviewHandler::HandleManagePrinters() in print_preview_handler.cc?
The CUPS Printing is also behind a command flag (--enable-native-cups) and
currently is targeting M56. I guess the MD setting should have been launched by
that moment? If not, I will need check with the PM to see if there is any other
option for this issue.

[dpapad, 2016/09/20 00:03:23]

I meant the one in print_preview.js. It seems more appropriate to handle the
event there.

[xdai1, 2016/09/20 17:31:29]

Done.

+        window.open(loadTimeData.getString('localPrintersManagementURL'));
+        return;
+      }
       cr.dispatchSimpleEvent(
           this,
           print_preview.DestinationSearch.EventType.MANAGE_LOCAL_DESTINATIONS);
     },
 
     /**
      * Called when the "Sign in" link on the Google Cloud Print promo is
      * activated.
      * @private
      */
@@ skipping 62 matching lines @@
     onWindowResize_: function() {
       this.reflowLists_();
     }
   };
 
   // Export
   return {
     DestinationSearch: DestinationSearch
   };
 });