[CUPS] Add a "Manage..." button in the local destinations section of Print Preview Dialog on Chrome…

chrome/browser/ui/webui/print_preview/print_preview_ui.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/print_preview/print_preview_ui.h"
 
 #include <map>
 #include <vector>
 
 #include "base/id_map.h"
@@ skipping 24 matching lines @@
 #include "content/public/browser/url_data_source.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/browser/web_ui_data_source.h"
 #include "printing/page_size_margins.h"
 #include "printing/print_job_constants.h"
 #include "ui/base/l10n/l10n_util.h"
 #include "ui/gfx/geometry/rect.h"
 #include "ui/web_dialogs/web_dialog_delegate.h"
 #include "ui/web_dialogs/web_dialog_ui.h"
 
+#if defined(OS_CHROMEOS)
+#include "base/command_line.h"
+#include "base/feature_list.h"
+#include "chrome/common/chrome_features.h"
+#include "chrome/common/chrome_switches.h"
+#endif
+
 using content::WebContents;
 using printing::PageSizeMargins;
 
 namespace {
 
 #if defined(OS_MACOSX)
 // U+0028 U+21E7 U+2318 U+0050 U+0029 in UTF8
 const char kBasicPrintShortcut[] = "\x28\xE2\x8c\xA5\xE2\x8C\x98\x50\x29";
 #elif defined(OS_WIN) || defined(OS_CHROMEOS)
 const char kBasicPrintShortcut[] = "(Ctrl+Shift+P)";
@@ skipping 331 matching lines @@
   source->AddResourcePath("images/mobile.png", IDR_PRINT_PREVIEW_IMAGES_MOBILE);
   source->AddResourcePath("images/mobile_shared.png",
                           IDR_PRINT_PREVIEW_IMAGES_MOBILE_SHARED);
   source->SetDefaultResource(IDR_PRINT_PREVIEW_HTML);
   source->SetRequestFilter(base::Bind(&HandleRequestCallback));
   source->OverrideContentSecurityPolicyChildSrc("child-src 'self';");
   source->DisableDenyXFrameOptions();
   source->OverrideContentSecurityPolicyObjectSrc("object-src 'self';");
   source->AddLocalizedString("moreOptionsLabel", IDS_MORE_OPTIONS_LABEL);
   source->AddLocalizedString("lessOptionsLabel", IDS_LESS_OPTIONS_LABEL);
+#if defined(OS_CHROMEOS)
+  source->AddBoolean("showLocalManageButton",
+                     base::CommandLine::ForCurrentProcess()->HasSwitch(
+                         ::switches::kEnableNativeCups) &&
+                     base::FeatureList::IsEnabled(
+                         features::kMaterialDesignSettings));
+  source->AddString("localPrintersManagementURL",

[Dan Beam, 2016/09/21 20:56:25]

what do you think about this?

#if defined(OS_CHROMEOS)
  bool cups_and_md_settings = ... switch and feature checks ...;
  source->AddBoolean("showLocalManageButton", cups_and_md_settings);

  if (cups_and_md_settings) {
    source->AddString("localPrintersManagementURL",
                      chrome::kChromeUIMdCupsSettingsURL);
  }
#else
  source->AddBoolean("showLocalManageButton", true);
#endif

[xdai1, 2016/09/21 23:38:53]

Done.

+                    chrome::kChromeUIMdCupsSettingsURL);
+#else
+  source->AddBoolean("showLocalManageButton", true);

[Dan Beam, 2016/09/21 19:12:02]

i'm confused.  why should this be true on !chromeos?  md-settings (where you're
linking to) hasn't shipped on Mac, Windows, or Linux...

[xdai1, 2016/09/21 19:56:24]

"Manage" button has been on other systems before this change (see code here:
https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/s...).
On the other systems, it will open the system printer settings, see code here:
https://cs.chromium.org/chromium/src/chrome/browser/resources/print_preview/p....

+#endif
   return source;
 }
 
 PrintPreviewUI::TestingDelegate* g_testing_delegate = NULL;
 
 }  // namespace
 
 PrintPreviewUI::PrintPreviewUI(content::WebUI* web_ui)
     : ConstrainedWebDialogUI(web_ui),
       initial_preview_start_time_(base::TimeTicks::Now()),
@@ skipping 255 matching lines @@
 }
 
 void PrintPreviewUI::SetSelectedFileForTesting(const base::FilePath& path) {
   handler_->FileSelected(path, 0, NULL);
 }
 
 void PrintPreviewUI::SetPdfSavedClosureForTesting(
     const base::Closure& closure) {
   handler_->SetPdfSavedClosureForTesting(closure);
 }