Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2351003002: Remove GYP annotations from chrome, ui, tools GN files. (Closed)

Created:
4 years, 3 months ago by brettw
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, dominickn+watch_chromium.org, oshima+watch_chromium.org, tzik, pennymac+watch_chromium.org, arv+watch_chromium.org, dimich+watch_chromium.org, tapted, cbentzel+watch_chromium.org, Matt Giuca, chili+watch_chromium.org, fgorski+watch_chromium.org, devtools-reviews_chromium.org, chromium-apps-reviews_chromium.org, jbudorick+watch_chromium.org, extensions-reviews_chromium.org, petewil+watch_chromium.org, media-router+watch_chromium.org, nhiroki, asvitkine+watch_chromium.org, Michael Moss, romax+watch_chromium.org, wfh+watch_chromium.org, dewittj+watch_chromium.org, mikecase+watch_chromium.org, grt+watch_chromium.org, James Su, kinuko+fileapi, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove GYP annotations from chrome, ui, tools GN files. Since the GYP files have been removed, the "GYP version" annotations above targets can be removed. TBR=dpranke@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/181167d7b2fb14674191830b2510345eade71153 Cr-Commit-Position: refs/heads/master@{#419584}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -114 lines) Patch
M chrome/BUILD.gn View 11 chunks +3 lines, -22 lines 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/app/BUILD.gn View 3 chunks +0 lines, -6 lines 0 comments Download
M chrome/app/resources/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/app/theme/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/BUILD.gn View 7 chunks +0 lines, -14 lines 0 comments Download
M chrome/browser/android/offline_pages/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/apps/app_shim/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/budget_service/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/devtools/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/variations/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/profile_resetter/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/resources/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/safe_browsing/incident_reporting/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/engagement/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/omnibox/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/plugins/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/api/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/common/net/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/safe_browsing/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/linux/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/BUILD.gn View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/renderer/leak_detector/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/android/cast_emulator/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/android/chrome_public_test_support/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/media_router/BUILD.gn View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/tools/build/win/syzygy/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/BUILD.gn View 4 chunks +0 lines, -10 lines 0 comments Download
M tools/android/audio_focus_grabber/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/common/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/forwarder/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/forwarder2/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M tools/android/kerberos/SpnegoAuthenticator/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M tools/android/md5sum/BUILD.gn View 4 chunks +0 lines, -4 lines 0 comments Download
M tools/cygprofile/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/accelerated_widget_mac/BUILD.gn View 2 chunks +0 lines, -2 lines 0 comments Download
M ui/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/base/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gfx/x/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M ui/resources/BUILD.gn View 3 chunks +0 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brettw
4 years, 3 months ago (2016-09-19 21:20:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2351003002/1
4 years, 3 months ago (2016-09-19 21:21:29 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 21:57:51 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/181167d7b2fb14674191830b2510345eade71153 Cr-Commit-Position: refs/heads/master@{#419584}
4 years, 3 months ago (2016-09-19 22:00:23 UTC) #7
Dirk Pranke
4 years, 3 months ago (2016-09-19 23:50:14 UTC) #8
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698