Issue 2350973002: Fix IsCompiletimeErrorObject for precompiled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2350973002: Fix IsCompiletimeErrorObject for precompiled. (Closed)

Created:
4 years, 3 months ago by rmacnak

Modified:
4 years, 3 months ago

Reviewers:
hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	runtime/vm/dart_api_impl.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

hausner

LGTM. Is this just an optimization, or a correctness issue?

4 years, 3 months ago (2016-09-19 20:54:35 UTC) #3

rmacnak

Correctness. We're reinterpreting null as a class and reading a cid from it. (And failing ...

4 years, 3 months ago (2016-09-19 21:04:45 UTC) #4

rmacnak

4 years, 3 months ago (2016-09-19 21:11:34 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
7432d20eaac1aaebbd6bc8583df271fa7a6e3a79 (presubmit successful).