Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(851)

Unified Diff: src/objects.h

Issue 2350963004: [builtins] Move StringIndexOf to a C++ builtin. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/messages.cc ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index c5521063dd6b8bf31d400e142c39e37e2719c665..1059185ab86694563b103e2072ec75d8ce79c233 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -9331,8 +9331,8 @@ class String: public Name {
// Perform string match of pattern on subject, starting at start index.
// Caller must ensure that 0 <= start_index <= sub->length().
- static int IndexOf(Isolate* isolate, Handle<String> sub, Handle<String> pat,
- int start_index);
+ static Object* IndexOf(Isolate* isolate, Handle<Object> receiver,
+ Handle<Object> pattern, Handle<Object> position);
Franzi 2016/09/20 17:03:27 Can we use the same parameter name for the third p
petermarshall 2016/09/22 13:54:24 Yep I'll do all of that renaming here too
static Object* LastIndexOf(Isolate* isolate, Handle<Object> receiver,
Handle<Object> search, Handle<Object> position);
« no previous file with comments | « src/messages.cc ('k') | src/objects.cc » ('j') | src/objects.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698