Centralizes more shared code between ash and mash

ash/root_window_controller.h

Index: ash/root_window_controller.h
diff --git a/ash/root_window_controller.h b/ash/root_window_controller.h
index e42aa052e4b29c38fc1e0b18cad3831b3aa2f25b..bc9fd3f2db0b62db4b6b37f2f9f556b499aca78c 100644
--- a/ash/root_window_controller.h
+++ b/ash/root_window_controller.h
@@ -46,7 +46,6 @@ class ScopedCaptureClient;
 
 namespace ash {
 class AshWindowTreeHost;
-class AlwaysOnTopController;
 class DockedWindowLayoutManager;
 enum class LoginStatus;
 class PanelLayoutManager;
@@ -105,12 +104,12 @@ class ASH_EXPORT RootWindowController : public ShellObserver {
 
   WorkspaceController* workspace_controller();
 
-  AlwaysOnTopController* always_on_top_controller() {
-    return always_on_top_controller_.get();
-  }
-
   WmShelfAura* wm_shelf_aura() const { return wm_shelf_aura_.get(); }
 
+  WmRootWindowControllerAura* wm_root_window_controller() {
+    return wm_root_window_controller_;
+  }
+
   // Get touch HUDs associated with this root window controller.
   TouchHudDebug* touch_hud_debug() const { return touch_hud_debug_; }
   TouchHudProjection* touch_hud_projection() const {
@@ -222,6 +221,9 @@ class ASH_EXPORT RootWindowController : public ShellObserver {
   // Disables projection touch HUD.
   void DisableTouchHudProjection();
 
+  DockedWindowLayoutManager* docked_window_layout_manager();

[James Cook, 2016/09/21 22:03:19]

GetDockedWindowLayoutManager() and GetPanelLayoutManager() please

[sky, 2016/09/21 22:47:49]

Can you motivate that? The style guide says "Functions that are very cheap to
call may instead follow the style for variable names (all lower-case, with
underscores between words)." Ideally I would inline the implementation, but that
would mean having to include wm_root_window_controller.h here, which we try to
avoid in chromium style.

[James Cook, 2016/09/21 22:56:11]

I associate them with inline functions, but I agree that not including
wm_root_window_controller.h is better and the style guide does not mandate that
hacker_style() means inline, so keep them as-is.

+  PanelLayoutManager* panel_layout_manager();
+
   // Overridden from ShellObserver.
   void OnLoginStateChanged(LoginStatus status) override;
   void OnTouchHudProjectionToggled(bool enabled) override;
@@ -245,12 +247,6 @@ class ASH_EXPORT RootWindowController : public ShellObserver {
   // this must be deleted before the container is deleted.
   std::unique_ptr<aura::Window> mouse_event_target_;
 
-  // Manages layout of docked windows. Owned by DockedContainer.
-  DockedWindowLayoutManager* docked_layout_manager_;
-
-  // Manages layout of panels. Owned by PanelContainer.
-  PanelLayoutManager* panel_layout_manager_;
-
   std::unique_ptr<SystemWallpaperController> system_wallpaper_;
 
 #if defined(OS_CHROMEOS)
@@ -260,8 +256,6 @@ class ASH_EXPORT RootWindowController : public ShellObserver {
   std::unique_ptr<AshTouchExplorationManager> touch_exploration_manager_;
 #endif
 
-  std::unique_ptr<AlwaysOnTopController> always_on_top_controller_;
-
   // Heads-up displays for touch events. These HUDs are not owned by the root
   // window controller and manage their own lifetimes.
   TouchHudDebug* touch_hud_debug_;