Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2350953006: gn: Point to process_version_rc_template() from process_version()'s docs (Closed)

Created:
4 years, 3 months ago by Raphael Kubo da Costa (rakuco)
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke, brettw
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gn: Point to process_version_rc_template() from process_version()'s docs The documentation for process_version()'s |template_file| argument was outdated and corresponded to a previous iteration of https://codereview.chromium.org/2341673003 Update the docs and point to where the rc_template template currently is. R=brettw@chromium.org,dpranke@chromium.org Committed: https://crrev.com/73326001a1ce814fef68e64b28dc2f17fdcc18a8 Cr-Commit-Position: refs/heads/master@{#419818}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M build/util/process_version.gni View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
Raphael Kubo da Costa (rakuco)
4 years, 3 months ago (2016-09-20 08:07:08 UTC) #1
brettw
lgtm
4 years, 3 months ago (2016-09-20 17:13:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350953006/1
4 years, 3 months ago (2016-09-20 17:19:21 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 18:21:45 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/73326001a1ce814fef68e64b28dc2f17fdcc18a8 Cr-Commit-Position: refs/heads/master@{#419818}
4 years, 3 months ago (2016-09-20 18:23:32 UTC) #7
Dirk Pranke
4 years, 3 months ago (2016-09-20 21:40:17 UTC) #8
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698