Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: third_party/crashpad/crashpad/util/misc/metrics.cc

Issue 2350943003: Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/util/misc/metrics.cc
diff --git a/third_party/crashpad/crashpad/util/misc/metrics.cc b/third_party/crashpad/crashpad/util/misc/metrics.cc
index 6a363b1302a2b9e68d256fd1d503c4a5c7d74b77..6acfabd8f5e3a4a35cf099ab1ff812b5d79733f0 100644
--- a/third_party/crashpad/crashpad/util/misc/metrics.cc
+++ b/third_party/crashpad/crashpad/util/misc/metrics.cc
@@ -15,13 +15,39 @@
#include "util/misc/metrics.h"
#include "base/metrics/histogram_macros.h"
+#include "base/metrics/sparse_histogram.h"
+#include "build/build_config.h"
namespace crashpad {
+// static
void Metrics::CrashReportSize(FileHandle file) {
const FileOffset size = LoggingFileSizeByHandle(file);
UMA_HISTOGRAM_CUSTOM_COUNTS(
"Crashpad.CrashReportSize", size, 0, 5 * 1024 * 1024, 50);
}
+// static
+void Metrics::ExceptionCaptureResult(CaptureResult result) {
+ UMA_HISTOGRAM_ENUMERATION("Crashpad.ExceptionCaptureResult",
+ static_cast<int32_t>(result),
+ static_cast<int32_t>(CaptureResult::kMaxValue));
+}
+
+// static
+void Metrics::ExceptionCode(uint32_t exception_code) {
+#if defined(OS_WIN)
+ const char kExceptionCodeString[] = "Crashpad.ExceptionCode.Win";
Alexei Svitkine (slow) 2016/09/20 18:58:55 Nit: static Same as my comment on a CL last week
scottmg 2016/09/20 21:33:09 OK, I posted that change upstream.
+#elif defined(OS_MACOSX)
+ const char kExceptionCodeString[] = "Crashpad.ExceptionCode.Mac";
+#endif
+ UMA_HISTOGRAM_SPARSE_SLOWLY(kExceptionCodeString,
Alexei Svitkine (slow) 2016/09/20 18:58:55 This is fine to do (in terms of it not being a lit
scottmg 2016/09/20 21:33:09 Thanks.
+ static_cast<int32_t>(exception_code));
+}
+
+// static
+void Metrics::ExceptionEncountered() {
+ UMA_HISTOGRAM_COUNTS("Crashpad.ExceptionEncountered", 1);
+}
+
} // namespace crashpad

Powered by Google App Engine
This is Rietveld 408576698