Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string
0aeca5f12374 UMA changes based on Chromium-side review

Adds entries to histogram.xml for UMA_s added in Crashpad.

Requires https://codereview.chromium.org/2358023003/.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
Committed: https://crrev.com/ca7b105dc952bd2d9b2fd5aaf9563f25f15aa752
Cr-Commit-Position: refs/heads/master@{#420425}

[scottmg, 2016-09-19 22:17:37]

mark: roll
asvitkine: tools/metrics/histograms/histograms.xml

https://codereview.chromium.org/2350943003/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/util/misc/metrics.cc (right):

https://codereview.chromium.org/2350943003/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/util/misc/metrics.cc:43:
UMA_HISTOGRAM_SPARSE_SLOWLY(kExceptionCodeString,
asvitkine: We weren't certain if it was OK to pass a const char[] (rather than a
literal) as first argument to a UMA macro, is that OK?

[scottmg, 2016-09-19 22:17:40]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:18:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-09-19 22:20:47]

LGTM

<owner> should be a person and not a mailing list, right?

[scottmg, 2016-09-19 22:30:56]

On 2016/09/19 22:20:47, Mark Mentovai wrote:
> LGTM
> 
> <owner> should be a person and not a mailing list, right?

crashpad-dev@ would be ideal, but I don't see any examples of that from a quick
skim. (Oh, I see now <owner> can be repeated too. I can do that too, if it's
supposed to be real-people.)

[commit-bot: I haz the power, 2016-09-19 22:48:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 22:48:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[scottmg, 2016-09-19 22:52:43]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 22:53:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-19 23:18:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 23:18:26]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[scottmg, 2016-09-19 23:21:57]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 23:22:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-09-20 00:09:45]

scottmg wrote:
> On 2016/09/19 22:20:47, Mark Mentovai wrote:
> > LGTM
> > 
> > <owner> should be a person and not a mailing list, right?
> 
> crashpad-dev@ would be ideal, but I don't see any examples of that from a
quick
> skim. (Oh, I see now <owner> can be repeated too. I can do that too, if it's
> supposed to be real-people.)

I guess listing two is better than listing one if real people are required.

One-person OWNERS files suck and are discouraged. This isn’t as critical as
OWNERS, but still, why be so limited?

[scottmg, 2016-09-20 00:32:20]

Description was changed from

==========
Update Crashpad to 72a12e2e949770473549c125891faeaeee8eabd7

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

to

==========
Update Crashpad to Update Crashpad to 17167a1e579afb8cf87c2136cdf75f1d338ed234

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
 
Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

[scottmg, 2016-09-20 00:33:49]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[scottmg, 2016-09-20 00:34:36]

On 2016/09/20 00:09:45, Mark Mentovai wrote:
> scottmg wrote:
> > On 2016/09/19 22:20:47, Mark Mentovai wrote:
> > > LGTM
> > > 
> > > <owner> should be a person and not a mailing list, right?
> > 
> > crashpad-dev@ would be ideal, but I don't see any examples of that from a
> quick
> > skim. (Oh, I see now <owner> can be repeated too. I can do that too, if it's
> > supposed to be real-people.)
> 
> I guess listing two is better than listing one if real people are required.
> 
> One-person OWNERS files suck and are discouraged. This isn’t as critical as
> OWNERS, but still, why be so limited?

Updated, with a feeling of hope.

[commit-bot: I haz the power, 2016-09-20 00:34:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-09-20 01:33:48]

You’ve still got my LGTM. Let’s see what “Alexei Svitkine (very slow)” thinks.

[commit-bot: I haz the power, 2016-09-20 02:36:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 02:36:43]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Alexei Svitkine (slow), 2016-09-20 18:58:56]

https://codereview.chromium.org/2350943003/diff/80001/third_party/crashpad/cr...
File third_party/crashpad/crashpad/util/misc/metrics.cc (right):

https://codereview.chromium.org/2350943003/diff/80001/third_party/crashpad/cr...
third_party/crashpad/crashpad/util/misc/metrics.cc:40: const char
kExceptionCodeString[] = "Crashpad.ExceptionCode.Win";
Nit: static

Same as my comment on a CL last week - at least until Windows compiler becomes
smarter and generates better code for the syntax without it.

https://codereview.chromium.org/2350943003/diff/80001/third_party/crashpad/cr...
third_party/crashpad/crashpad/util/misc/metrics.cc:44:
UMA_HISTOGRAM_SPARSE_SLOWLY(kExceptionCodeString,
This is fine to do (in terms of it not being a literal).

https://codereview.chromium.org/2350943003/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2350943003/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:7410: +<histogram
name="Crashpad.ExceptionCode.Mac">
Please make an enum for this too, even if you don't fully fill it in. Having
enum= set makes our dashboard treat it as an enum - as opposed to numeric - so
it won't try to do percentiles and other useless stuff.

https://codereview.chromium.org/2350943003/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:7422: +  <summary>A count of the number
of exceptions handled by Crashpad.</summary>
This is not logging a count - it's logging a boolean sample every time an
exception is handled instead. Please re-word to make that clear and associate
this with a enum="BooleanHit".

However, as a meta question, we don't generally encourage these kinds of metrics
- because numbers in isolation are not meaningful unless you compare to
something.

For example, is 198 a lot? Very few? Hard to say unless you have some other
information such as number of launches, number of users, or some other
denominator.

[scottmg, 2016-09-20 21:33:10]

Thanks

https://codereview.chromium.org/2350943003/diff/80001/third_party/crashpad/cr...
File third_party/crashpad/crashpad/util/misc/metrics.cc (right):

https://codereview.chromium.org/2350943003/diff/80001/third_party/crashpad/cr...
third_party/crashpad/crashpad/util/misc/metrics.cc:40: const char
kExceptionCodeString[] = "Crashpad.ExceptionCode.Win";
On 2016/09/20 18:58:55, Alexei Svitkine (very slow) wrote:
> Nit: static
> 
> Same as my comment on a CL last week - at least until Windows compiler becomes
> smarter and generates better code for the syntax without it.
> 
> 

OK, I posted that change upstream.

https://codereview.chromium.org/2350943003/diff/80001/third_party/crashpad/cr...
third_party/crashpad/crashpad/util/misc/metrics.cc:44:
UMA_HISTOGRAM_SPARSE_SLOWLY(kExceptionCodeString,
On 2016/09/20 18:58:55, Alexei Svitkine (very slow) wrote:
> This is fine to do (in terms of it not being a literal).

Thanks.

https://codereview.chromium.org/2350943003/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2350943003/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:7410: +<histogram
name="Crashpad.ExceptionCode.Mac">
On 2016/09/20 18:58:55, Alexei Svitkine (very slow) wrote:
> Please make an enum for this too, even if you don't fully fill it in. Having
> enum= set makes our dashboard treat it as an enum - as opposed to numeric - so
> it won't try to do percentiles and other useless stuff.

Done. Just added a few that I could find easily that seemed plausibly useful.

https://codereview.chromium.org/2350943003/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:7422: +  <summary>A count of the number
of exceptions handled by Crashpad.</summary>
On 2016/09/20 18:58:55, Alexei Svitkine (very slow) wrote:
> This is not logging a count - it's logging a boolean sample every time an
> exception is handled instead. Please re-word to make that clear and associate
> this with a enum="BooleanHit".
> 
> However, as a meta question, we don't generally encourage these kinds of
metrics
> - because numbers in isolation are not meaningful unless you compare to
> something.
> 
> For example, is 198 a lot? Very few? Hard to say unless you have some other
> information such as number of launches, number of users, or some other
> denominator.

The idea was that this is a count we can compare against the count of
ExceptionCaptureResult (which tracks all the exits from the function). This one
is here so that it's set right away as early as possible, and then we can infer
if Crashpad is crashing by a difference in these counts.

[scottmg, 2016-09-20 22:14:35]

Description was changed from

==========
Update Crashpad to Update Crashpad to 17167a1e579afb8cf87c2136cdf75f1d338ed234

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
 
Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

to

==========
Update Crashpad to Update Crashpad to 007f790fe21c75ec9ce8c5892457e4f08941f10f

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

[scottmg, 2016-09-20 22:15:58]

Description was changed from

==========
Update Crashpad to Update Crashpad to 007f790fe21c75ec9ce8c5892457e4f08941f10f

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

to

==========
Update Crashpad to Update Crashpad to 007f790fe21c75ec9ce8c5892457e4f08941f10f

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

[scottmg, 2016-09-20 22:16:24]

Rolled to next rev for static.

[scottmg, 2016-09-20 22:25:28]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 22:26:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2016-09-20 23:15:55]

Still LGTM

[commit-bot: I haz the power, 2016-09-21 00:22:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:22:01]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Alexei Svitkine (slow), 2016-09-21 15:47:17]

https://codereview.chromium.org/2350943003/diff/80001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2350943003/diff/80001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:7422: +  <summary>A count of the number
of exceptions handled by Crashpad.</summary>
On 2016/09/20 21:33:09, scottmg wrote:
> On 2016/09/20 18:58:55, Alexei Svitkine (very slow) wrote:
> > This is not logging a count - it's logging a boolean sample every time an
> > exception is handled instead. Please re-word to make that clear and
associate
> > this with a enum="BooleanHit".
> > 
> > However, as a meta question, we don't generally encourage these kinds of
> metrics
> > - because numbers in isolation are not meaningful unless you compare to
> > something.
> > 
> > For example, is 198 a lot? Very few? Hard to say unless you have some other
> > information such as number of launches, number of users, or some other
> > denominator.
> 
> The idea was that this is a count we can compare against the count of
> ExceptionCaptureResult (which tracks all the exits from the function). This
one
> is here so that it's set right away as early as possible, and then we can
infer
> if Crashpad is crashing by a difference in these counts.

I see. Comparing the difference of the two results seems like it would be
tedious to do. So I suggest actually adding another bucket to this histogram
(i.e. making an enum with two enums) that's logged when ExceptionCaptureResult
is logged - so that you can clearly do the comparison you want within the same
histogram.

(If you do that, make a helper function that logs that histogram and call it
from both places - so you don't repeat the macro for the same histogram since
the macros does expand to a bunch of code.)

[scottmg, 2016-09-21 19:30:47]

Description was changed from

==========
Update Crashpad to Update Crashpad to 007f790fe21c75ec9ce8c5892457e4f08941f10f

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

to

==========
Update Crashpad to Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string
0aeca5f12374 UMA changes based on Chromium-side review

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

[scottmg, 2016-09-21 19:34:40]

Description was changed from

==========
Update Crashpad to Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string
0aeca5f12374 UMA changes based on Chromium-side review

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

to

==========
Update Crashpad to Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string
0aeca5f12374 UMA changes based on Chromium-side review

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

[scottmg, 2016-09-21 19:36:46]

The CQ bit was checked by scottmg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 19:37:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2016-09-21 20:04:15]

Description was changed from

==========
Update Crashpad to Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string
0aeca5f12374 UMA changes based on Chromium-side review

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

to

==========
Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string
0aeca5f12374 UMA changes based on Chromium-side review

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

[commit-bot: I haz the power, 2016-09-21 21:54:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 21:54:23]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[scottmg, 2016-09-22 17:59:10]

Description was changed from

==========
Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string
0aeca5f12374 UMA changes based on Chromium-side review

Adds entries to histogram.xml for UMA_s added in Crashpad.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

to

==========
Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string
0aeca5f12374 UMA changes based on Chromium-side review

Adds entries to histogram.xml for UMA_s added in Crashpad.

Requires https://codereview.chromium.org/2358023003/.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

[scottmg, 2016-09-22 17:59:47]

Updated roll, ready to go once https://codereview.chromium.org/2358023003/
lands.

[Alexei Svitkine (slow), 2016-09-22 18:17:34]

lgtm

[Mark Mentovai, 2016-09-22 18:20:29]

LGTM

[scottmg, 2016-09-22 18:37:38]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-09-22 18:38:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 19:33:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 19:33:27]

Failed to apply the patch.
On branch working_branch
Your branch is up-to-date with 'origin/refs/pending/heads/master'.
nothing to commit, working tree clean

[scottmg, 2016-09-22 19:34:46]

On 2016/09/22 19:33:27, commit-bot: I haz the power wrote:
> Failed to apply the patch.
> On branch working_branch
> Your branch is up-to-date with 'origin/refs/pending/heads/master'.
> nothing to commit, working tree clean

That's a compellingly interesting message that I don't understand. I'll try the
turn it off and on again approach I guess.

[scottmg, 2016-09-22 19:34:51]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-09-22 19:35:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 19:36:58]

Description was changed from

==========
Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string
0aeca5f12374 UMA changes based on Chromium-side review

Adds entries to histogram.xml for UMA_s added in Crashpad.

Requires https://codereview.chromium.org/2358023003/.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100
==========

to

==========
Update Crashpad to 0aeca5f12374fdbf3d4f6c656abf950ba2a96f1c

b48e9bfbabf3 Add UMA to exception handler exception catching
72a12e2e9497 Make UMA for exception code OS-specific
17167a1e579a static_cast UMA 'enum class's to int
007f790fe21c static const on const char[] for UMA string
0aeca5f12374 UMA changes based on Chromium-side review

Adds entries to histogram.xml for UMA_s added in Crashpad.

Requires https://codereview.chromium.org/2358023003/.

R=mark@chromium.org, asvitkine@chromium.org
BUG=crashpad:100

Committed: https://crrev.com/ca7b105dc952bd2d9b2fd5aaf9563f25f15aa752
Cr-Commit-Position: refs/heads/master@{#420425}
==========

[commit-bot: I haz the power, 2016-09-22 19:36:59]

Patchset 9 (id:??) landed as
https://crrev.com/ca7b105dc952bd2d9b2fd5aaf9563f25f15aa752
Cr-Commit-Position: refs/heads/master@{#420425}