Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2350933007: Make sure to use the correct context for eval checks (Closed)

Created:
4 years, 3 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 3 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Make sure to use the correct context for eval checks We can't assume that there's no entered context during microtask execution. We also can't assume that we'll never enter an context during microtask execution either. We can however assume that we don't execute microtasks recursively, so remembering the length of the entered context stack is enough to decide which context to use. BUG=chromium:635769 R=verwaest@chromium.org Committed: https://crrev.com/d008b9efcbddf299feefe7b420fd7e1601512ba5 Cr-Commit-Position: refs/heads/master@{#39627}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M src/api.h View 5 chunks +10 lines, -0 lines 0 comments Download
M src/builtins/builtins.cc View 1 1 chunk +5 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
jochen (gone - plz use gerrit)
4 years, 3 months ago (2016-09-20 13:15:16 UTC) #1
Toon Verwaest
lgtm
4 years, 3 months ago (2016-09-22 13:02:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350933007/20001
4 years, 3 months ago (2016-09-22 13:04:01 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-22 13:38:43 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 13:38:55 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d008b9efcbddf299feefe7b420fd7e1601512ba5
Cr-Commit-Position: refs/heads/master@{#39627}

Powered by Google App Engine
This is Rietveld 408576698