Android: In incognito, links never open in external apps if possible.

Android: In incognito, links never open in external apps if possible.

When clicking a link that can either be handled by the browser, or by an
external app, in incognito mode we now automatically choose the browser,
to keep the user within incognito mode as much as possible. Links that
can only be handled externally (e.g., intent:// and other system
schemes) are unchanged (prompt the user, then send an external intent).

Added a test that an intent:// URL in incognito mode will still prompt.

BUG=587306
Committed: https://crrev.com/7189731c3d87496bbb62aba9e125ce341296c66b
Cr-Commit-Position: refs/heads/master@{#419984}

[Matt Giuca, 2016-09-20 08:54:09]

Description was changed from

==========
Android: In incognito, links never open in external apps if possible.

When clicking a link that can either be handled by the browser, or by an
external app, in incognito mode we now automatically choose the browser,
to keep the user within incognito mode as much as possible. Links that
can only be handled externally (e.g., intent:// and other system
schemes) are unchanged (prompt the user, then send an external intent).

BUG=587306
==========

to

==========
Android: In incognito, links never open in external apps if possible.

When clicking a link that can either be handled by the browser, or by an
external app, in incognito mode we now automatically choose the browser,
to keep the user within incognito mode as much as possible. Links that
can only be handled externally (e.g., intent:// and other system
schemes) are unchanged (prompt the user, then send an external intent).

Added a test that an intent:// URL in incognito mode will still prompt.

BUG=587306
==========

[Matt Giuca, 2016-09-20 08:55:44]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 08:56:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 09:28:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 09:28:37]

Dry run: This issue passed the CQ dry run.

[Matt Giuca, 2016-09-21 00:54:58]

mgiuca@chromium.org changed reviewers:
+ mariakhomenko@chromium.org

[Matt Giuca, 2016-09-21 00:54:58]

Hi Maria,

See discussion on https://crbug.com/587306, particularly #13, #22 and #27. This
is Darin's proposal, which people in that thread are referring to as "13.2".

[Matt Giuca, 2016-09-21 03:03:39]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 03:04:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 03:30:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 03:30:45]

Dry run: This issue passed the CQ dry run.

[Maria, 2016-09-21 04:18:19]

lgtm

[Matt Giuca, 2016-09-21 05:44:07]

The CQ bit was checked by mgiuca@chromium.org

[commit-bot: I haz the power, 2016-09-21 05:44:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 05:49:49]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-21 05:52:08]

Description was changed from

==========
Android: In incognito, links never open in external apps if possible.

When clicking a link that can either be handled by the browser, or by an
external app, in incognito mode we now automatically choose the browser,
to keep the user within incognito mode as much as possible. Links that
can only be handled externally (e.g., intent:// and other system
schemes) are unchanged (prompt the user, then send an external intent).

Added a test that an intent:// URL in incognito mode will still prompt.

BUG=587306
==========

to

==========
Android: In incognito, links never open in external apps if possible.

When clicking a link that can either be handled by the browser, or by an
external app, in incognito mode we now automatically choose the browser,
to keep the user within incognito mode as much as possible. Links that
can only be handled externally (e.g., intent:// and other system
schemes) are unchanged (prompt the user, then send an external intent).

Added a test that an intent:// URL in incognito mode will still prompt.

BUG=587306

Committed: https://crrev.com/7189731c3d87496bbb62aba9e125ce341296c66b
Cr-Commit-Position: refs/heads/master@{#419984}
==========

[commit-bot: I haz the power, 2016-09-21 05:52:08]

Patchset 4 (id:??) landed as
https://crrev.com/7189731c3d87496bbb62aba9e125ce341296c66b
Cr-Commit-Position: refs/heads/master@{#419984}