Issue 235093002: remove guard for getTotalClip

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235093002: remove guard for getTotalClip (Closed)

Created:
6 years, 8 months ago by reed1

Modified:
6 years, 8 months ago

Reviewers:

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

More Reviews

Description

remove guard for getTotalClip TBR=robertphilips@google.com Committed: http://code.google.com/p/skia/source/detail?r=14153

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	gyp/skia_for_chromium_defines.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/235093002/1

6 years, 8 months ago (2014-04-11 12:10:48 UTC) #2

Stephen White

6 years, 8 months ago (2014-04-12 01:03:39 UTC) #4

Message was sent while issue was closed.

On 2014/04/11 15:54:09, I haz the power (commit-bot) wrote:
> Change committed as 14153

Looks like this breaks the Mac Chrome build:

../../skia/ext/skia_utils_mac.mm:407:42: error: no member named 'getTotalClip'
in 'SkCanvas'
      const SkRegion& clipRgn = canvas_->getTotalClip();
                                ~~~~~~~  ^

but maybe I'm missing something.

Expand Messages | Collapse Messages