Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Side by Side Diff: Source/core/rendering/svg/SVGRenderSupport.cpp

Issue 23509003: Address regression bug report, revert the PaintInfo rect member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Including revision in cl. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org> 2 * Copyright (C) 2007, 2008 Rob Buis <buis@kde.org>
3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org> 3 * Copyright (C) 2007 Nikolas Zimmermann <zimmermann@kde.org>
4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org> 4 * Copyright (C) 2007 Eric Seidel <eric@webkit.org>
5 * Copyright (C) 2009 Google, Inc. All rights reserved. 5 * Copyright (C) 2009 Google, Inc. All rights reserved.
6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org> 6 * Copyright (C) 2009 Dirk Schulze <krit@webkit.org>
7 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 strokeBoundingBox.unite(transform.mapRect(current->repaintRectInLoca lCoordinates())); 149 strokeBoundingBox.unite(transform.mapRect(current->repaintRectInLoca lCoordinates()));
150 } 150 }
151 } 151 }
152 152
153 repaintBoundingBox = strokeBoundingBox; 153 repaintBoundingBox = strokeBoundingBox;
154 } 154 }
155 155
156 bool SVGRenderSupport::paintInfoIntersectsRepaintRect(const FloatRect& localRepa intRect, const AffineTransform& localTransform, const PaintInfo& paintInfo) 156 bool SVGRenderSupport::paintInfoIntersectsRepaintRect(const FloatRect& localRepa intRect, const AffineTransform& localTransform, const PaintInfo& paintInfo)
157 { 157 {
158 if (localTransform.isIdentity()) 158 if (localTransform.isIdentity())
159 return localRepaintRect.intersects(paintInfo.rect()); 159 return localRepaintRect.intersects(paintInfo.rect);
160 160
161 return localTransform.mapRect(localRepaintRect).intersects(paintInfo.rect()) ; 161 return localTransform.mapRect(localRepaintRect).intersects(paintInfo.rect);
162 } 162 }
163 163
164 const RenderSVGRoot* SVGRenderSupport::findTreeRootObject(const RenderObject* st art) 164 const RenderSVGRoot* SVGRenderSupport::findTreeRootObject(const RenderObject* st art)
165 { 165 {
166 while (start && !start->isSVGRoot()) 166 while (start && !start->isSVGRoot())
167 start = start->parent(); 167 start = start->parent();
168 168
169 ASSERT(start); 169 ASSERT(start);
170 ASSERT(start->isSVGRoot()); 170 ASSERT(start->isSVGRoot());
171 return toRenderSVGRoot(start); 171 return toRenderSVGRoot(start);
(...skipping 219 matching lines...) Expand 10 before | Expand all | Expand 10 after
391 391
392 bool SVGRenderSupport::isEmptySVGInlineText(const RenderObject* object) 392 bool SVGRenderSupport::isEmptySVGInlineText(const RenderObject* object)
393 { 393 {
394 // RenderSVGInlineText performs whitespace filtering in order to support xml :space 394 // RenderSVGInlineText performs whitespace filtering in order to support xml :space
395 // (http://www.w3.org/TR/SVG/struct.html#LangSpaceAttrs), and can end up wit h an empty string 395 // (http://www.w3.org/TR/SVG/struct.html#LangSpaceAttrs), and can end up wit h an empty string
396 // even when its original constructor argument is non-empty. 396 // even when its original constructor argument is non-empty.
397 return object->isSVGInlineText() && toRenderSVGInlineText(object)->hasEmptyT ext(); 397 return object->isSVGInlineText() && toRenderSVGInlineText(object)->hasEmptyT ext();
398 } 398 }
399 399
400 } 400 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderWidget.cpp ('k') | Source/core/rendering/svg/SVGRenderingContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698