Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: Source/core/rendering/RenderTableSection.cpp

Issue 23509003: Address regression bug report, revert the PaintInfo rect member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Including revision in cl. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderTableCell.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2008, 2009, 2010 Apple Inc. All rights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 1319 matching lines...) Expand 10 before | Expand all | Expand 10 after
1330 } 1330 }
1331 1331
1332 return CellSpan(startColumn, endColumn); 1332 return CellSpan(startColumn, endColumn);
1333 } 1333 }
1334 1334
1335 1335
1336 void RenderTableSection::paintObject(PaintInfo& paintInfo, const LayoutPoint& pa intOffset) 1336 void RenderTableSection::paintObject(PaintInfo& paintInfo, const LayoutPoint& pa intOffset)
1337 { 1337 {
1338 PaintPhase paintPhase = paintInfo.phase; 1338 PaintPhase paintPhase = paintInfo.phase;
1339 1339
1340 LayoutRect localRepaintRect = paintInfo.rect(); 1340 LayoutRect localRepaintRect = paintInfo.rect;
1341 localRepaintRect.moveBy(-paintOffset); 1341 localRepaintRect.moveBy(-paintOffset);
1342 localRepaintRect.inflate(maximalOutlineSize(paintPhase)); 1342 localRepaintRect.inflate(maximalOutlineSize(paintPhase));
1343 1343
1344 LayoutRect tableAlignedRect = logicalRectForWritingModeAndDirection(localRep aintRect); 1344 LayoutRect tableAlignedRect = logicalRectForWritingModeAndDirection(localRep aintRect);
1345 1345
1346 CellSpan dirtiedRows = this->dirtiedRows(tableAlignedRect); 1346 CellSpan dirtiedRows = this->dirtiedRows(tableAlignedRect);
1347 CellSpan dirtiedColumns = this->dirtiedColumns(tableAlignedRect); 1347 CellSpan dirtiedColumns = this->dirtiedColumns(tableAlignedRect);
1348 1348
1349 if (dirtiedColumns.start() < dirtiedColumns.end()) { 1349 if (dirtiedColumns.start() < dirtiedColumns.end()) {
1350 if (!m_hasMultipleCellLevels && !m_overflowingCells.size()) { 1350 if (!m_hasMultipleCellLevels && !m_overflowingCells.size()) {
(...skipping 332 matching lines...) Expand 10 before | Expand all | Expand 10 after
1683 if (!style()->isLeftToRightDirection()) 1683 if (!style()->isLeftToRightDirection())
1684 cellLocation.setX(table()->columnPositions()[table()->numEffCols()] - ta ble()->columnPositions()[table()->colToEffCol(cell->col() + cell->colSpan())] + horizontalBorderSpacing); 1684 cellLocation.setX(table()->columnPositions()[table()->numEffCols()] - ta ble()->columnPositions()[table()->colToEffCol(cell->col() + cell->colSpan())] + horizontalBorderSpacing);
1685 else 1685 else
1686 cellLocation.setX(table()->columnPositions()[effectiveColumn] + horizont alBorderSpacing); 1686 cellLocation.setX(table()->columnPositions()[effectiveColumn] + horizont alBorderSpacing);
1687 1687
1688 cell->setLogicalLocation(cellLocation); 1688 cell->setLogicalLocation(cellLocation);
1689 view()->addLayoutDelta(oldCellLocation - cell->location()); 1689 view()->addLayoutDelta(oldCellLocation - cell->location());
1690 } 1690 }
1691 1691
1692 } // namespace WebCore 1692 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTableCell.cpp ('k') | Source/core/rendering/RenderView.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698