Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Side by Side Diff: Source/core/rendering/RenderTableCell.cpp

Issue 23509003: Address regression bug report, revert the PaintInfo rect member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Including revision in cl. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderTable.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 1074 matching lines...) Expand 10 before | Expand all | Expand 10 after
1085 compareBorderValuesForQSort); 1085 compareBorderValuesForQSort);
1086 } 1086 }
1087 1087
1088 void RenderTableCell::paintCollapsedBorders(PaintInfo& paintInfo, const LayoutPo int& paintOffset) 1088 void RenderTableCell::paintCollapsedBorders(PaintInfo& paintInfo, const LayoutPo int& paintOffset)
1089 { 1089 {
1090 ASSERT(paintInfo.phase == PaintPhaseCollapsedTableBorders); 1090 ASSERT(paintInfo.phase == PaintPhaseCollapsedTableBorders);
1091 1091
1092 if (!paintInfo.shouldPaintWithinRoot(this) || style()->visibility() != VISIB LE) 1092 if (!paintInfo.shouldPaintWithinRoot(this) || style()->visibility() != VISIB LE)
1093 return; 1093 return;
1094 1094
1095 LayoutRect localRepaintRect = paintInfo.rect(); 1095 LayoutRect localRepaintRect = paintInfo.rect;
1096 localRepaintRect.inflate(maximalOutlineSize(paintInfo.phase)); 1096 localRepaintRect.inflate(maximalOutlineSize(paintInfo.phase));
1097 1097
1098 LayoutRect paintRect = LayoutRect(paintOffset + location(), pixelSnappedSize ()); 1098 LayoutRect paintRect = LayoutRect(paintOffset + location(), pixelSnappedSize ());
1099 if (paintRect.y() - table()->outerBorderTop() >= localRepaintRect.maxY()) 1099 if (paintRect.y() - table()->outerBorderTop() >= localRepaintRect.maxY())
1100 return; 1100 return;
1101 1101
1102 if (paintRect.maxY() + table()->outerBorderBottom() <= localRepaintRect.y()) 1102 if (paintRect.maxY() + table()->outerBorderBottom() <= localRepaintRect.y())
1103 return; 1103 return;
1104 1104
1105 GraphicsContext* graphicsContext = paintInfo.context; 1105 GraphicsContext* graphicsContext = paintInfo.context;
(...skipping 154 matching lines...) Expand 10 before | Expand all | Expand 10 after
1260 1260
1261 RenderTableCell* RenderTableCell::createAnonymousWithParentRenderer(const Render Object* parent) 1261 RenderTableCell* RenderTableCell::createAnonymousWithParentRenderer(const Render Object* parent)
1262 { 1262 {
1263 RenderTableCell* newCell = RenderTableCell::createAnonymous(parent->document ()); 1263 RenderTableCell* newCell = RenderTableCell::createAnonymous(parent->document ());
1264 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_CELL); 1264 RefPtr<RenderStyle> newStyle = RenderStyle::createAnonymousStyleWithDisplay( parent->style(), TABLE_CELL);
1265 newCell->setStyle(newStyle.release()); 1265 newCell->setStyle(newStyle.release());
1266 return newCell; 1266 return newCell;
1267 } 1267 }
1268 1268
1269 } // namespace WebCore 1269 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderTable.cpp ('k') | Source/core/rendering/RenderTableSection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698