Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: Source/core/rendering/RenderTable.cpp

Issue 23509003: Address regression bug report, revert the PaintInfo rect member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Including revision in cl. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderReplica.cpp ('k') | Source/core/rendering/RenderTableCell.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1997 Martin Jones (mjones@kde.org) 2 * Copyright (C) 1997 Martin Jones (mjones@kde.org)
3 * (C) 1997 Torben Weis (weis@kde.org) 3 * (C) 1997 Torben Weis (weis@kde.org)
4 * (C) 1998 Waldo Bastian (bastian@kde.org) 4 * (C) 1998 Waldo Bastian (bastian@kde.org)
5 * (C) 1999 Lars Knoll (knoll@kde.org) 5 * (C) 1999 Lars Knoll (knoll@kde.org)
6 * (C) 1999 Antti Koivisto (koivisto@kde.org) 6 * (C) 1999 Antti Koivisto (koivisto@kde.org)
7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved. 7 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All r ights reserved.
8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com) 8 * Copyright (C) 2006 Alexey Proskuryakov (ap@nypop.com)
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 617 matching lines...) Expand 10 before | Expand all | Expand 10 after
628 628
629 LayoutPoint adjustedPaintOffset = paintOffset + location(); 629 LayoutPoint adjustedPaintOffset = paintOffset + location();
630 630
631 PaintPhase paintPhase = paintInfo.phase; 631 PaintPhase paintPhase = paintInfo.phase;
632 632
633 if (!isRoot()) { 633 if (!isRoot()) {
634 LayoutRect overflowBox = visualOverflowRect(); 634 LayoutRect overflowBox = visualOverflowRect();
635 flipForWritingMode(overflowBox); 635 flipForWritingMode(overflowBox);
636 overflowBox.inflate(maximalOutlineSize(paintInfo.phase)); 636 overflowBox.inflate(maximalOutlineSize(paintInfo.phase));
637 overflowBox.moveBy(adjustedPaintOffset); 637 overflowBox.moveBy(adjustedPaintOffset);
638 if (!overflowBox.intersects(paintInfo.rect())) 638 if (!overflowBox.intersects(paintInfo.rect))
639 return; 639 return;
640 } 640 }
641 641
642 bool pushedClip = pushContentsClip(paintInfo, adjustedPaintOffset, ForceCont entsClip); 642 bool pushedClip = pushContentsClip(paintInfo, adjustedPaintOffset, ForceCont entsClip);
643 paintObject(paintInfo, adjustedPaintOffset); 643 paintObject(paintInfo, adjustedPaintOffset);
644 if (pushedClip) 644 if (pushedClip)
645 popContentsClip(paintInfo, paintPhase, adjustedPaintOffset); 645 popContentsClip(paintInfo, paintPhase, adjustedPaintOffset);
646 } 646 }
647 647
648 void RenderTable::paintObject(PaintInfo& paintInfo, const LayoutPoint& paintOffs et) 648 void RenderTable::paintObject(PaintInfo& paintInfo, const LayoutPoint& paintOffs et)
(...skipping 792 matching lines...) Expand 10 before | Expand all | Expand 10 after
1441 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const 1441 const BorderValue& RenderTable::tableEndBorderAdjoiningCell(const RenderTableCel l* cell) const
1442 { 1442 {
1443 ASSERT(cell->isFirstOrLastCellInRow()); 1443 ASSERT(cell->isFirstOrLastCellInRow());
1444 if (hasSameDirectionAs(cell->row())) 1444 if (hasSameDirectionAs(cell->row()))
1445 return style()->borderEnd(); 1445 return style()->borderEnd();
1446 1446
1447 return style()->borderStart(); 1447 return style()->borderStart();
1448 } 1448 }
1449 1449
1450 } 1450 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderReplica.cpp ('k') | Source/core/rendering/RenderTableCell.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698