Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Side by Side Diff: Source/core/rendering/RenderReplica.cpp

Issue 23509003: Address regression bug report, revert the PaintInfo rect member function. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Including revision in cl. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/rendering/RenderReplaced.cpp ('k') | Source/core/rendering/RenderTable.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2008 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 74
75 if (paintInfo.phase != PaintPhaseForeground && paintInfo.phase != PaintPhase Mask) 75 if (paintInfo.phase != PaintPhaseForeground && paintInfo.phase != PaintPhase Mask)
76 return; 76 return;
77 77
78 LayoutPoint adjustedPaintOffset = paintOffset + location(); 78 LayoutPoint adjustedPaintOffset = paintOffset + location();
79 79
80 if (paintInfo.phase == PaintPhaseForeground) { 80 if (paintInfo.phase == PaintPhaseForeground) {
81 // Turn around and paint the parent layer. Use temporary clipRects, so t hat the layer doesn't end up caching clip rects 81 // Turn around and paint the parent layer. Use temporary clipRects, so t hat the layer doesn't end up caching clip rects
82 // computing using the wrong rootLayer 82 // computing using the wrong rootLayer
83 RenderLayer* rootPaintingLayer = layer()->transform() ? layer()->parent( ) : layer()->enclosingTransformedAncestor(); 83 RenderLayer* rootPaintingLayer = layer()->transform() ? layer()->parent( ) : layer()->enclosingTransformedAncestor();
84 RenderLayer::LayerPaintingInfo paintingInfo(rootPaintingLayer, paintInfo .rect(), PaintBehaviorNormal, LayoutSize(), 0, paintInfo.renderRegion); 84 RenderLayer::LayerPaintingInfo paintingInfo(rootPaintingLayer, paintInfo .rect, PaintBehaviorNormal, LayoutSize(), 0, paintInfo.renderRegion);
85 RenderLayer::PaintLayerFlags flags = RenderLayer::PaintLayerHaveTranspar ency | RenderLayer::PaintLayerAppliedTransform | RenderLayer::PaintLayerTemporar yClipRects | RenderLayer::PaintLayerPaintingReflection; 85 RenderLayer::PaintLayerFlags flags = RenderLayer::PaintLayerHaveTranspar ency | RenderLayer::PaintLayerAppliedTransform | RenderLayer::PaintLayerTemporar yClipRects | RenderLayer::PaintLayerPaintingReflection;
86 layer()->parent()->paintLayer(paintInfo.context, paintingInfo, flags); 86 layer()->parent()->paintLayer(paintInfo.context, paintingInfo, flags);
87 } else if (paintInfo.phase == PaintPhaseMask) 87 } else if (paintInfo.phase == PaintPhaseMask)
88 paintMask(paintInfo, adjustedPaintOffset); 88 paintMask(paintInfo, adjustedPaintOffset);
89 } 89 }
90 90
91 } // namespace WebCore 91 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderReplaced.cpp ('k') | Source/core/rendering/RenderTable.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698