Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: net/quic/core/quic_connection_test.cc

Issue 2350863002: Deprecate FLAGS_quic_do_not_send_ack_on_emsgsize. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/core/quic_connection.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/core/quic_connection_test.cc
diff --git a/net/quic/core/quic_connection_test.cc b/net/quic/core/quic_connection_test.cc
index be154ebefa86a2c21a17152680054d142dd2ebe9..428fb0e9902575ef3a275668a11241d559ace11d 100644
--- a/net/quic/core/quic_connection_test.cc
+++ b/net/quic/core/quic_connection_test.cc
@@ -5211,26 +5211,7 @@ TEST_P(QuicConnectionTest, NotBecomeApplicationLimitedDueToWriteBlock) {
connection_.SendStreamData3();
}
-TEST_P(QuicConnectionTest, ForceSendingAckOnPacketTooLarge) {
- FLAGS_quic_do_not_send_ack_on_emsgsize = false;
- EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
- // Send an ack by simulating delayed ack alarm firing.
- ProcessPacket(kDefaultPathId, 1);
- QuicAlarm* ack_alarm = QuicConnectionPeer::GetAckAlarm(&connection_);
- EXPECT_TRUE(ack_alarm->IsSet());
- connection_.GetAckAlarm()->Fire();
- // Simulate data packet causes write error.
- EXPECT_CALL(visitor_, OnConnectionClosed(QUIC_PACKET_WRITE_ERROR, _, _));
- SimulateNextPacketTooLarge();
- connection_.SendStreamDataWithString(3, "foo", 0, !kFin, nullptr);
- EXPECT_EQ(3u, writer_->frame_count());
- EXPECT_FALSE(writer_->connection_close_frames().empty());
- // Ack frame is bundled.
- EXPECT_FALSE(writer_->ack_frames().empty());
-}
-
TEST_P(QuicConnectionTest, DonotForceSendingAckOnPacketTooLarge) {
- FLAGS_quic_do_not_send_ack_on_emsgsize = true;
EXPECT_CALL(visitor_, OnSuccessfulVersionNegotiation(_));
// Send an ack by simulating delayed ack alarm firing.
ProcessPacket(kDefaultPathId, 1);
« no previous file with comments | « net/quic/core/quic_connection.cc ('k') | net/quic/core/quic_flags_list.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698