Make the buttons on task-page work

Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

When retrying a task, all the current properties of the task are
copied into the new task and "(retry)" is appended to the name.
Additionally, the user field is set to be whoever is logged in.
If the retry is successfully requested, the task page will auto
redirect to it.

The refresh interval actually works, making the stdout and milo refresh.

The Requested Dimensions now has a link to the botlist with
all those dimensions, so one can see which bots could pick up a
given task.

The times on task-page now have their full timestamps as mouseovers.

BUG=631047
Committed: https://github.com/luci/luci-py/commit/aac687d9ab71b04582a39e8ec3230c4579ec93e2

[kjlubick, 2016-09-20 20:16:26]

Description was changed from

==========
Add task-page button functionality

BUG=
==========

to

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

Additionally, the refresh interval actually works, making
the stdout and milo refresh.

BUG=
==========

[kjlubick, 2016-09-21 11:46:30]

Description was changed from

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

Additionally, the refresh interval actually works, making
the stdout and milo refresh.

BUG=
==========

to

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

Additionally, the refresh interval actually works, making
the stdout and milo refresh.

BUG=631047
==========

[kjlubick, 2016-09-21 12:01:58]

Description was changed from

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

Additionally, the refresh interval actually works, making
the stdout and milo refresh.

BUG=631047
==========

to

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

When retrying a task, all the current properties of the task are
copied into the new task and "(retry)" is appended to the name.
Additionally, the user field is set to be whoever is logged in.

Additionally, the refresh interval actually works, making
the stdout and milo refresh.

BUG=631047
==========

[kjlubick, 2016-09-21 12:37:33]

Description was changed from

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

When retrying a task, all the current properties of the task are
copied into the new task and "(retry)" is appended to the name.
Additionally, the user field is set to be whoever is logged in.

Additionally, the refresh interval actually works, making
the stdout and milo refresh.

BUG=631047
==========

to

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

When retrying a task, all the current properties of the task are
copied into the new task and "(retry)" is appended to the name.
Additionally, the user field is set to be whoever is logged in.
If the retry is successfully requested, the task page will auto
redirect to it.

The refresh interval actually works, making the stdout and milo refresh.



BUG=631047
==========

[kjlubick, 2016-09-21 13:19:36]

Description was changed from

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

When retrying a task, all the current properties of the task are
copied into the new task and "(retry)" is appended to the name.
Additionally, the user field is set to be whoever is logged in.
If the retry is successfully requested, the task page will auto
redirect to it.

The refresh interval actually works, making the stdout and milo refresh.



BUG=631047
==========

to

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

When retrying a task, all the current properties of the task are
copied into the new task and "(retry)" is appended to the name.
Additionally, the user field is set to be whoever is logged in.
If the retry is successfully requested, the task page will auto
redirect to it.

The refresh interval actually works, making the stdout and milo refresh.

The Requested Dimensions now has a link to the botlist with
all those dimensions, so one can see which bots could pick up a
given task.

The times on task-page now have their full timestamps as mouseovers.

BUG=631047
==========

[kjlubick, 2016-09-21 13:20:15]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-09-21 13:20:16]

Try out the retrying on the staging server:
https://2341-3f797a9-tainted-kjlubick-dot-chromium-swarm-dev.appspot.com/newu...

[jcgregorio, 2016-09-21 14:22:04]

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/common/common-behavior.html:118: //
)timeDiffApprox returns the approximate difference between now and
_timeDiffApprox

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/common/interval-timer.html (right):

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/common/interval-timer.html:37: if
(this.timeout) {
rename timeout -> _timeout since it isn't a public property of the element.

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/taskpage/task-page.html (right):

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/taskpage/task-page.html:514: 
No blank line.

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/taskpage/task-page.html:685:
this._auth_headers, newTask).then(function(response) {
The value of 'response' will the error message returned from the server in the
case postWithToast falls into it's catch case.

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/res/js/common.js (right):

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/js/common.js:72: return reason;
Now there's no way to distinguish the value returned from the promise upon
success or failure.

[kjlubick, 2016-09-21 14:51:38]

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/common/common-behavior.html (right):

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/common/common-behavior.html:118: //
)timeDiffApprox returns the approximate difference between now and
On 2016/09/21 at 14:22:03, jcgregorio wrote:
> _timeDiffApprox

Typing is hard.  Done.

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/common/interval-timer.html (right):

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/common/interval-timer.html:37: if
(this.timeout) {
On 2016/09/21 at 14:22:03, jcgregorio wrote:
> rename timeout -> _timeout since it isn't a public property of the element.

Done.

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/res/imp/taskpage/task-page.html (right):

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/taskpage/task-page.html:514: 
On 2016/09/21 at 14:22:03, jcgregorio wrote:
> No blank line.

Done.

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/imp/taskpage/task-page.html:685:
this._auth_headers, newTask).then(function(response) {
On 2016/09/21 at 14:22:03, jcgregorio wrote:
> The value of 'response' will the error message returned from the server in the
case postWithToast falls into it's catch case.

Fixed.

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
File appengine/swarming/elements/res/js/common.js (right):

https://codereview.chromium.org/2350853004/diff/120001/appengine/swarming/ele...
appengine/swarming/elements/res/js/common.js:72: return reason;
On 2016/09/21 at 14:22:03, jcgregorio wrote:
> Now there's no way to distinguish the value returned from the promise upon
success or failure.

Fixed.

[jcgregorio, 2016-09-21 14:52:44]

lgtm

[KevinL, 2016-09-21 18:06:42]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-09-21 18:06:43]

lgtm

[KevinL, 2016-09-21 18:06:46]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-09-21 18:06:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 18:10:05]

Description was changed from

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

When retrying a task, all the current properties of the task are
copied into the new task and "(retry)" is appended to the name.
Additionally, the user field is set to be whoever is logged in.
If the retry is successfully requested, the task page will auto
redirect to it.

The refresh interval actually works, making the stdout and milo refresh.

The Requested Dimensions now has a link to the botlist with
all those dimensions, so one can see which bots could pick up a
given task.

The times on task-page now have their full timestamps as mouseovers.

BUG=631047
==========

to

==========
Make the buttons on task-page work

You can now cancel and retry tasks from the task-page.

When retrying a task, all the current properties of the task are
copied into the new task and "(retry)" is appended to the name.
Additionally, the user field is set to be whoever is logged in.
If the retry is successfully requested, the task page will auto
redirect to it.

The refresh interval actually works, making the stdout and milo refresh.

The Requested Dimensions now has a link to the botlist with
all those dimensions, so one can see which bots could pick up a
given task.

The times on task-page now have their full timestamps as mouseovers.

BUG=631047

Committed:
https://github.com/luci/luci-py/commit/aac687d9ab71b04582a39e8ec3230c4579ec93e2
==========

[commit-bot: I haz the power, 2016-09-21 18:10:07]

Committed patchset #8 (id:140001) as
https://github.com/luci/luci-py/commit/aac687d9ab71b04582a39e8ec3230c4579ec93e2