Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2350843005: Set TTFB and total request time from new CronetMetrics constructor (Closed)

Created:
4 years, 3 months ago by mgersh
Modified:
4 years, 3 months ago
Reviewers:
xunjieli
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set TTFB and total request time from new CronetMetrics constructor These are deprecated and will be removed soon, but for a while we'll want to set them using the new way of collecting metrics. BUG=629194 Committed: https://crrev.com/738d43b9110e96768a6d8803ca0bd2365a60daab Cr-Commit-Position: refs/heads/master@{#419851}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M components/cronet/android/java/src/org/chromium/net/impl/CronetMetrics.java View 1 chunk +11 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 8 (3 generated)
mgersh
4 years, 3 months ago (2016-09-20 20:48:40 UTC) #2
xunjieli
lgtm
4 years, 3 months ago (2016-09-20 20:55:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350843005/1
4 years, 3 months ago (2016-09-20 20:56:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-20 21:05:37 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 21:07:12 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/738d43b9110e96768a6d8803ca0bd2365a60daab
Cr-Commit-Position: refs/heads/master@{#419851}

Powered by Google App Engine
This is Rietveld 408576698