Issue 235083004: Introduce Object::DebugGetProperty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235083004: Introduce Object::DebugGetProperty. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Introduce Object::DebugGetProperty. R=ulan@chromium.org

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+86 lines, -113 lines)			Patch
M	src/objects.h	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	src/objects.cc	View	1 chunk	+19 lines, -32 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+42 lines, -0 lines	0 comments	Download
M	src/runtime.cc	View	3 chunks	+11 lines, -81 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

Are the changes below intended? https://codereview.chromium.org/235083004/diff/1/src/runtime.cc File src/runtime.cc (left): https://codereview.chromium.org/235083004/diff/1/src/runtime.cc#oldcode10750 src/runtime.cc:10750: if (structure->IsForeign() || structure->IsAccessorInfo()) ...

6 years, 8 months ago (2014-04-14 08:39:35 UTC) #2

Yang

6 years, 8 months ago (2014-04-14 09:09:42 UTC) #3

On 2014/04/14 08:39:35, ulan wrote:
> Are the changes below intended?
> 
> https://codereview.chromium.org/235083004/diff/1/src/runtime.cc
> File src/runtime.cc (left):
> 
> https://codereview.chromium.org/235083004/diff/1/src/runtime.cc#oldcode10750
> src/runtime.cc:10750: if (structure->IsForeign() ||
structure->IsAccessorInfo())
> {
> After this change, we no longer check for: structure->IsForeign() ||
> structure->IsAccessorInfo()
> 
> https://codereview.chromium.org/235083004/diff/1/src/runtime.cc#oldcode10769
> src/runtime.cc:10769: return heap->undefined_value();
> After this change, this can return other values.

You are right. I rewrote the entire thing and uploaded it as a separate CL.

Expand Messages | Collapse Messages