Issue 235083002: Reland "Handlify GetProperty."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 235083002: Reland "Handlify GetProperty." (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+258 lines, -349 lines)			Patch
M	src/api.cc	View		5 chunks	+11 lines, -9 lines	0 comments	Download
M	src/bootstrapper.cc	View		5 chunks	+8 lines, -8 lines	0 comments	Download
M	src/debug.cc	View		4 chunks	+8 lines, -8 lines	0 comments	Download
M	src/execution.cc	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/factory.cc	View		3 chunks	+5 lines, -6 lines	0 comments	Download
M	src/handles.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/i18n.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/isolate.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/liveedit.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	src/liveedit.cc	View		7 chunks	+15 lines, -15 lines	0 comments	Download
M	src/log.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/messages.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/objects.h	View		7 chunks	+14 lines, -38 lines	0 comments	Download
M	src/objects.cc	View	1	15 chunks	+80 lines, -182 lines	0 comments	Download
M	src/objects-inl.h	View		3 chunks	+36 lines, -18 lines	0 comments	Download
M	src/runtime.cc	View		3 chunks	+14 lines, -9 lines	0 comments	Download
M	test/cctest/test-api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-compiler.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	test/cctest/test-heap.cc	View		15 chunks	+37 lines, -29 lines	0 comments	Download
M	test/cctest/test-mark-compact.cc	View		2 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Yang

Second patch set is the fix. The issue is that result->holder() is not a JSObject ...

6 years, 8 months ago (2014-04-11 12:12:57 UTC) #1

Yang

6 years, 8 months ago (2014-04-11 12:47:50 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20689 (presubmit successful).