third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.h - Issue 2350813005: bindings: Support sequence in callback function arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.h

Issue 2350813005: bindings: Support sequence in callback function arguments (Closed)

Patch Set: Pass ExceptionState Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/tests/idls/core/TestObject.idl ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8StringSequenceCallbackFunctionSequenceLongArg.cpp ('k') | third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.h

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.h b/third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.h

index 8da22c8da3db14d9f44f5c0efff4fdc1ce2961bc..6427e5142282026675f20c209e800d57c96b732e 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.h

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.h

@@ -7,6 +7,7 @@

#ifndef V8VoidExperimentalCallbackFunction_h

#define V8VoidExperimentalCallbackFunction_h

+#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/ScopedPersistent.h"

#include "core/CoreExport.h"

#include "platform/heap/Handle.h"

@@ -27,7 +28,7 @@ public:

DECLARE_TRACE();

- bool call(ScriptState* scriptState, ScriptWrappable* scriptWrappable);

+ bool call(ScriptState* scriptState, ScriptWrappable* scriptWrappable, ExceptionState& exceptionState);

v8::Local<v8::Function> v8Value(v8::Isolate* isolate)

{