Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp

Issue 2350813005: bindings: Support sequence in callback function arguments (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
diff --git a/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp b/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
index cb38bc761f133afb5976e611f87d31bc877e5517..04a3d8cbf30704fee256e65205f858fe4b43d653 100644
--- a/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
+++ b/third_party/WebKit/Source/core/testing/CallbackFunctionTest.cpp
@@ -9,6 +9,7 @@
#include "bindings/core/v8/V8TestCallback.h"
#include "bindings/core/v8/V8TestInterfaceCallback.h"
#include "bindings/core/v8/V8TestReceiverObjectCallback.h"
+#include "bindings/core/v8/V8TestSequenceCallback.h"
#include "core/html/HTMLDivElement.h"
namespace blink {
@@ -22,7 +23,7 @@ String CallbackFunctionTest::testCallback(ScriptState* scriptState, V8TestCallba
ScriptWrappable* scriptWrappable;
String returnValue;
- if (callback->call(scriptState, scriptWrappable = nullptr, message1, message2, returnValue)) {
+ if (callback->call(scriptState, scriptWrappable = nullptr, exceptionState, message1, message2, returnValue)) {
return String("SUCCESS: ") + returnValue;
}
return String("Error!");
@@ -32,14 +33,23 @@ void CallbackFunctionTest::testInterfaceCallback(ScriptState* scriptState, V8Tes
{
ScriptWrappable* scriptWrappable;
- callback->call(scriptState, scriptWrappable = nullptr, divElement);
+ callback->call(scriptState, scriptWrappable = nullptr, exceptionState, divElement);
return;
}
void CallbackFunctionTest::testReceiverObjectCallback(ScriptState* scriptState, V8TestReceiverObjectCallback* callback, ExceptionState& exceptionState)
{
- callback->call(scriptState, this);
+ callback->call(scriptState, this, exceptionState);
return;
}
+Vector<String> CallbackFunctionTest::testSequenceCallback(ScriptState* scriptState, V8TestSequenceCallback* callback, const Vector<int>& numbers, ExceptionState& exceptionState)
+{
+ Vector<String> returnValue;
+ if (callback->call(scriptState, nullptr, exceptionState, numbers, returnValue)) {
+ return returnValue;
+ }
+ return Vector<String>();
+}
+
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698