third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp - Issue 2350813005: bindings: Support sequence in callback function arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

Issue 2350813005: bindings: Support sequence in callback function arguments (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/BUILD.gn ('k') | third_party/WebKit/Source/bindings/scripts/v8_callback_function.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

index 88386581c5e24a1e497e71ed37b3d3ee77fe09aa..45fdb9809542e01c5cb98607424bb9c2dbd34b9e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerformanceObserverCallback.cpp

@@ -33,7 +33,8 @@ void V8PerformanceObserverCallback::handleEvent(PerformanceObserverEntryList* en

if (!canInvokeCallback())

return;

- m_callback->call(m_scriptState.get(), observer, entries, observer);

+ TrackExceptionState exceptionState;

+ m_callback->call(m_scriptState.get(), observer, exceptionState, entries, observer);

}

DEFINE_TRACE(V8PerformanceObserverCallback)