third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp - Issue 2350813005: bindings: Support sequence in callback function arguments

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp

Issue 2350813005: bindings: Support sequence in callback function arguments (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/bindings/tests/results/core/V8LongExperimentalCallbackFunction.cpp ('K') | « third_party/WebKit/Source/bindings/tests/results/core/V8VoidCallbackFunctionSequenceStringArg.cpp ('k') | third_party/WebKit/Source/core/testing/CallbackFunctionTest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp

diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp

index 56704495e31a4ff73142a0d59e02b71becc9243c..49e7f3f5c6192c6aa818c7eac2af1ddf7710926f 100644

--- a/third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp

+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8VoidExperimentalCallbackFunction.cpp

@@ -6,7 +6,9 @@

#include "V8VoidExperimentalCallbackFunction.h"

+#include "bindings/core/v8/ExceptionState.h"

#include "bindings/core/v8/ScriptState.h"

+#include "bindings/core/v8/ToV8.h"

#include "bindings/core/v8/V8Binding.h"

#include "wtf/Assertions.h"

@@ -30,7 +32,9 @@ bool V8VoidExperimentalCallbackFunction::call(ScriptState* scriptState, ScriptWr

if (m_callback.isEmpty())

return false;

ScriptState::Scope scope(scriptState);

+ ExceptionState exceptionState(scriptState->isolate(), ExceptionState::ExecutionContext, "VoidExperimentalCallbackFunction");

v8::Local<v8::Value> *argv = nullptr;