NoState Prefetch: CSP test

chrome/browser/prerender/prerender_nostate_prefetch_test.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/command_line.h"
 #include "base/strings/string_split.h"
 #include "chrome/browser/prerender/prerender_manager.h"
 #include "chrome/browser/prerender/prerender_manager_factory.h"
 #include "chrome/browser/prerender/prerender_test_utils.h"
 #include "chrome/browser/profiles/profile.h"
@@ skipping 22 matching lines @@
 namespace prerender {
 
 // The various uses of URLs in these tests (the test server, request capture,
 // etc) are fussy about relative versus absolute paths. With the exception of
 // kPrefetchLoaderPath, which is only used in PrerenderTestURLImpl, all other
 // paths should be relative.
 const char kPrefetchImagePage[] = "prerender/prefetch_image.html";
 const char kPrefetchLoopPage[] = "prerender/prefetch_loop.html";
 const char kPrefetchJpeg[] = "prerender/image.jpeg";
 const char kPrefetchLoaderPath[] = "/prerender/prefetch_loader.html";
+const char kPrefetchMetaCSP[] = "prerender/prefetch_meta_csp.html";

[pasko, 2016/10/05 14:09:55]

I liked how you sorted these before, what made you undo it?

[mattcary, 2016/10/12 15:09:10]

There may be a merge thing here: the names are sorted alphabetically, and I
(hopefully) maintained that.

[pasko, 2016/10/12 15:48:55]

kPrefetchLoopPage[] looks misordered ..

[mattcary, 2016/10/13 08:44:27]

Gah, thanks. Rebasing is hard.

 const char kPrefetchPage[] = "prerender/prefetch_page.html";
 const char kPrefetchPage2[] = "prerender/prefetch_page2.html";
 const char kPrefetchPng[] = "prerender/image.png";
+const char kPrefetchResponseHeaderCSP[] =
+    "prerender/prefetch_response_csp.html";
 const char kPrefetchScript[] = "prerender/prefetch.js";
 const char kPrefetchScript2[] = "prerender/prefetch2.js";
 const char kPrefetchSubresourceRedirectPage[] =
     "prerender/prefetch_subresource_redirect.html";
 
 const char kPageBool[] = "pageBool";
 const char kScriptBool[] = "scriptBool";
 
 class NoStatePrefetchBrowserTest
     : public test_utils::PrerenderInProcessBrowserTest {
  public:
   NoStatePrefetchBrowserTest() {}
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     PrerenderInProcessBrowserTest::SetUpCommandLine(command_line);
     command_line->AppendSwitchASCII(
         switches::kPrerenderMode, switches::kPrerenderModeSwitchValuePrefetch);
   }
 
-  // Set up a request counter for the path.
+  // Set up a request counter for a path. The url used will be derived from
+  // |path|, which also provides that data served.
   void CountRequestFor(const std::string& path, RequestCounter* counter) {
     GURL::Replacements replacement;
     replacement.SetPathStr(path);
     const GURL url = src_server()->base_url().ReplaceComponents(replacement);
+    CountRequestForUrl(url, path, counter);
+  }
+
+  // Set up a request counter for a specific URL, serving data from |path|.
+  void CountRequestForUrl(const GURL& url,
+                       const std::string& path,
+                       RequestCounter* counter) {
     base::FilePath url_file =
         ui_test_utils::GetTestFilePath(base::FilePath(), base::FilePath(path));
     content::BrowserThread::PostTask(
         content::BrowserThread::IO, FROM_HERE,
         base::Bind(&CreateCountingInterceptorOnIO, url, url_file,
                    counter->AsWeakPtr()));
   }
 
   // Fetches a boolean value from javascript. Returns whether the fetch
   // succeeded; the value of the variable is returned in value. If
@@ skipping 166 matching lines @@
   GURL cross_domain_url(base::StringPrintf(
       "http://%s:%d/%s", secondary_domain.c_str(),
       embedded_test_server()->host_port_pair().port(), kPrefetchPage));
   PrerenderTestURL(cross_domain_url, FINAL_STATUS_APP_TERMINATING, 1);
   histogram_tester().ExpectTotalCount("Prerender.PerceivedPLT", 1);
   histogram_tester().ExpectTotalCount("Prerender.none_PerceivedPLT", 1);
   histogram_tester().ExpectTotalCount(
       "Prerender.webcross_PrerenderNotSwappedInPLT", 1);
 }
 
+// Check that response header CSP is handled correctly.

[pasko, 2016/10/05 14:09:55]

Preferable: s/is handled correctly/prevents fetching a script from disallowed
domain/.

[mattcary, 2016/10/12 15:09:10]

Done.

+IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, ResponseHeaderCSP) {
+  static const std::string secondary_domain = "foo.bar";
+  host_resolver()->AddRule(secondary_domain, "127.0.0.1");
+  RequestCounter main_page;
+  CountRequestFor(kPrefetchResponseHeaderCSP, &main_page);
+  RequestCounter first_script;
+  CountRequestFor(kPrefetchScript, &first_script);
+  RequestCounter second_script;
+  GURL second_script_url(std::string("http://foo.bar/") + kPrefetchScript2);
+  CountRequestForUrl(second_script_url, kPrefetchScript2, &second_script);
+  PrerenderTestURL(kPrefetchResponseHeaderCSP, FINAL_STATUS_APP_TERMINATING, 1);
+  // The second script is in the correct domain for CSP, but the first script is
+  // not.
+  main_page.WaitForCount(1);
+  second_script.WaitForCount(1);
+  first_script.WaitForCount(0);
+}
+
+// Check CSP in the meta tag cancels the prefetch.
+
+// TODO(mattcary): probably this behavior should be consistent with
+// response-header CSP. See crbug/XXX.
+IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, MetaTagCSP) {
+  static const std::string secondary_domain = "foo.bar";
+  host_resolver()->AddRule(secondary_domain, "127.0.0.1");
+  RequestCounter main_page;
+  CountRequestFor(kPrefetchMetaCSP, &main_page);
+  RequestCounter first_script;
+  CountRequestFor(kPrefetchScript, &first_script);
+  RequestCounter second_script;
+  GURL second_script_url(std::string("http://foo.bar/") + kPrefetchScript2);
+  CountRequestForUrl(second_script_url, kPrefetchScript2, &second_script);
+  PrerenderTestURL(kPrefetchMetaCSP, FINAL_STATUS_APP_TERMINATING, 1);
+  // TODO(mattcary): See test comment above. If the meta CSP tag were parsed,
+  // |second_script| would be loaded. Instead as the background scanner bails as
+  // soon as the meta CSP tag is seen, only |main_page| is fetched.
+  main_page.WaitForCount(1);
+  second_script.WaitForCount(0);
+  first_script.WaitForCount(0);
+}
+
 // Check that we support simultaneous prefetch.
 IN_PROC_BROWSER_TEST_F(NoStatePrefetchBrowserTest, PrefetchSimultaneous) {
   RequestCounter first_main_counter;
   CountRequestFor(kPrefetchPage, &first_main_counter);
   RequestCounter second_main_counter;
   CountRequestFor(kPrefetchPage2, &second_main_counter);
   RequestCounter first_script_counter;
   CountRequestFor(kPrefetchScript, &first_script_counter);
   RequestCounter second_script_counter;
   CountRequestFor(kPrefetchScript2, &second_script_counter);
@@ skipping 192 matching lines @@
       url, safe_browsing::SB_THREAT_TYPE_URL_MALWARE);
   // Prefetch resource are blocked, but the prerender is not killed in any
   // special way.
   // TODO(mattcary): do we care about detecting if the main resource is fetched
   // and preload scanning has started?
   std::unique_ptr<TestPrerender> prerender =
       PrerenderTestURL(kPrefetchPage, FINAL_STATUS_APP_TERMINATING, 0);
 }
 
 }  // namespace prerender