Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 2350813002: Fixing regression in Windows Host Package GN target (Closed)

Created:
4 years, 3 months ago by joedow
Modified:
4 years, 3 months ago
Reviewers:
Jamie
CC:
chromium-reviews, chromoting-reviews_chromium.org, nicholss
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fixing regression in Windows Host Package GN target A recent GN change (https://codereview.chromium.org/2308813002) broke the target used for building our signed package as it removed one of the binaries. This change adds the binary back so we can resume getting signed MSIs. BUG= Committed: https://crrev.com/6e62062f712747ac80273b529c31f9cebe5a919d Cr-Commit-Position: refs/heads/master@{#419493}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M remoting/host/installer/win/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
joedow
PTAL!
4 years, 3 months ago (2016-09-19 17:10:01 UTC) #4
Jamie
lgtm
4 years, 3 months ago (2016-09-19 17:18:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350813002/1
4 years, 3 months ago (2016-09-19 17:20:25 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 17:25:44 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 17:28:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e62062f712747ac80273b529c31f9cebe5a919d
Cr-Commit-Position: refs/heads/master@{#419493}

Powered by Google App Engine
This is Rietveld 408576698