Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Side by Side Diff: components/sync/core/processor_entity_tracker_unittest.cc

Issue 2350803005: [Sync] Fixing two bugs in the worker revealed by trying to add an encryption integration test. (Closed)
Patch Set: Removing debugging log statements. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/sync/core/processor_entity_tracker.h" 5 #include "components/sync/core/processor_entity_tracker.h"
6 6
7 #include <stdint.h> 7 #include <stdint.h>
8 8
9 #include <memory> 9 #include <memory>
10 #include <utility> 10 #include <utility>
(...skipping 451 matching lines...) Expand 10 before | Expand all | Expand 10 after
462 462
463 // Ack the first commit. 463 // Ack the first commit.
464 entity->ReceiveCommitResponse(GenerateAckData(request_v1, kId, 2)); 464 entity->ReceiveCommitResponse(GenerateAckData(request_v1, kId, 2));
465 465
466 EXPECT_EQ(2, entity->metadata().sequence_number()); 466 EXPECT_EQ(2, entity->metadata().sequence_number());
467 EXPECT_EQ(1, entity->metadata().acked_sequence_number()); 467 EXPECT_EQ(1, entity->metadata().acked_sequence_number());
468 EXPECT_EQ(2, entity->metadata().server_version()); 468 EXPECT_EQ(2, entity->metadata().server_version());
469 EXPECT_EQ(specifics_hash_v2, entity->metadata().specifics_hash()); 469 EXPECT_EQ(specifics_hash_v2, entity->metadata().specifics_hash());
470 EXPECT_EQ(specifics_hash_v1, entity->metadata().base_specifics_hash()); 470 EXPECT_EQ(specifics_hash_v1, entity->metadata().base_specifics_hash());
471 471
472 EXPECT_TRUE(entity->IsUnsynced());
maxbogue 2016/09/21 00:57:14 Thanks!
skym 2016/09/22 18:58:46 Acknowledged.
473 EXPECT_FALSE(entity->RequiresCommitRequest());
474 EXPECT_FALSE(entity->RequiresCommitData());
475 EXPECT_FALSE(entity->CanClearMetadata());
476 EXPECT_TRUE(entity->HasCommitData());
477
472 // Ack the second commit. 478 // Ack the second commit.
473 entity->ReceiveCommitResponse(GenerateAckData(request_v2, kId, 3)); 479 entity->ReceiveCommitResponse(GenerateAckData(request_v2, kId, 3));
474 480
475 EXPECT_EQ(2, entity->metadata().sequence_number()); 481 EXPECT_EQ(2, entity->metadata().sequence_number());
476 EXPECT_EQ(2, entity->metadata().acked_sequence_number()); 482 EXPECT_EQ(2, entity->metadata().acked_sequence_number());
477 EXPECT_EQ(3, entity->metadata().server_version()); 483 EXPECT_EQ(3, entity->metadata().server_version());
478 EXPECT_EQ(specifics_hash_v2, entity->metadata().specifics_hash()); 484 EXPECT_EQ(specifics_hash_v2, entity->metadata().specifics_hash());
479 EXPECT_EQ("", entity->metadata().base_specifics_hash()); 485 EXPECT_EQ("", entity->metadata().base_specifics_hash());
480 486
481 EXPECT_FALSE(entity->IsUnsynced()); 487 EXPECT_FALSE(entity->IsUnsynced());
482 EXPECT_FALSE(entity->RequiresCommitRequest()); 488 EXPECT_FALSE(entity->RequiresCommitRequest());
483 EXPECT_FALSE(entity->RequiresCommitData()); 489 EXPECT_FALSE(entity->RequiresCommitData());
484 EXPECT_FALSE(entity->CanClearMetadata()); 490 EXPECT_FALSE(entity->CanClearMetadata());
485 EXPECT_FALSE(entity->HasCommitData()); 491 EXPECT_FALSE(entity->HasCommitData());
486 } 492 }
487 493
488 } // namespace syncer_v2 494 } // namespace syncer_v2
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698