Added UMA actions to devices page

Added UMA actions to devices page

Added UMA actions for devices page, including for when it is opened, when "add
printers" is clicked, when "register" is clicked, when a registration is
canceled, when a registration fails, and when a registration succeeds.

BUG=286157
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221913

[Noam Samuel, 2013-09-05 23:01:10]

+jar for extract_actions.py

[jar (doing other things), 2013-09-06 00:45:20]

Forward to Ilya for extract_actions.py

[Ilya Sherman, 2013-09-06 00:53:32]

tools/metrics/actions/ LGTM

https://codereview.chromium.org/23508003/diff/1/tools/metrics/actions/extract...
File tools/metrics/actions/extract_actions.py (right):

https://codereview.chromium.org/23508003/diff/1/tools/metrics/actions/extract...
tools/metrics/actions/extract_actions.py:602: AddDevicesPageActions(actions)
nit: While you're here, let's alphabetize these calls.

[Vitaly Buka (NO REVIEWS), 2013-09-06 04:02:54]

lgtm

[Vitaly Buka (NO REVIEWS), 2013-09-06 06:21:08]

lgtm

https://chromiumcodereview.appspot.com/23508003/diff/1/tools/metrics/actions/...
File tools/metrics/actions/extract_actions.py (right):

https://chromiumcodereview.appspot.com/23508003/diff/1/tools/metrics/actions/...
tools/metrics/actions/extract_actions.py:602: AddDevicesPageActions(actions)
On 2013/09/06 00:53:32, Ilya Sherman wrote:
> nit: While you're here, let's alphabetize these calls.

I'll enable CQ now as-is and if it's committed by morning I'll fix in separate
CL.

[commit-bot: I haz the power, 2013-09-06 06:21:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/23508003/1

[commit-bot: I haz the power, 2013-09-06 06:21:29]

Failed to apply patch for
chrome/browser/local_discovery/cloud_print_base_api_flow.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/local_discovery/cloud_print_base_api_flow.cc
  Hunk #1 FAILED at 3.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/local_discovery/cloud_print_base_api_flow.cc.rej

Patch:       chrome/browser/local_discovery/cloud_print_base_api_flow.cc
Index: chrome/browser/local_discovery/cloud_print_base_api_flow.cc
diff --git a/chrome/browser/local_discovery/cloud_print_base_api_flow.cc
b/chrome/browser/local_discovery/cloud_print_base_api_flow.cc
index
8420d4ef5aac57bdc90445063e335bf4679c0051..28a73a22a61ac107587b1a4c2b095c137bbe9439
100644
--- a/chrome/browser/local_discovery/cloud_print_base_api_flow.cc
+++ b/chrome/browser/local_discovery/cloud_print_base_api_flow.cc
@@ -3,16 +3,16 @@
 // found in the LICENSE file.
 
 #include "base/json/json_reader.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "chrome/browser/local_discovery/cloud_print_base_api_flow.h"
 #include "chrome/common/cloud_print/cloud_print_constants.h"
 #include "google_apis/gaia/google_service_auth_error.h"
 #include "net/base/load_flags.h"
+#include "net/base/url_util.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/url_request_status.h"
-#include "base/strings/string_number_conversions.h"
-#include "net/base/url_util.h"
 
 namespace local_discovery {

[commit-bot: I haz the power, 2013-09-06 06:54:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/23508003/1

[commit-bot: I haz the power, 2013-09-06 06:54:17]

Failed to apply patch for
chrome/browser/local_discovery/cloud_print_base_api_flow.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/local_discovery/cloud_print_base_api_flow.cc
  Hunk #1 FAILED at 3.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/local_discovery/cloud_print_base_api_flow.cc.rej

Patch:       chrome/browser/local_discovery/cloud_print_base_api_flow.cc
Index: chrome/browser/local_discovery/cloud_print_base_api_flow.cc
diff --git a/chrome/browser/local_discovery/cloud_print_base_api_flow.cc
b/chrome/browser/local_discovery/cloud_print_base_api_flow.cc
index
8420d4ef5aac57bdc90445063e335bf4679c0051..28a73a22a61ac107587b1a4c2b095c137bbe9439
100644
--- a/chrome/browser/local_discovery/cloud_print_base_api_flow.cc
+++ b/chrome/browser/local_discovery/cloud_print_base_api_flow.cc
@@ -3,16 +3,16 @@
 // found in the LICENSE file.
 
 #include "base/json/json_reader.h"
+#include "base/strings/string_number_conversions.h"
 #include "base/strings/stringprintf.h"
 #include "base/values.h"
 #include "chrome/browser/local_discovery/cloud_print_base_api_flow.h"
 #include "chrome/common/cloud_print/cloud_print_constants.h"
 #include "google_apis/gaia/google_service_auth_error.h"
 #include "net/base/load_flags.h"
+#include "net/base/url_util.h"
 #include "net/http/http_status_code.h"
 #include "net/url_request/url_request_status.h"
-#include "base/strings/string_number_conversions.h"
-#include "net/base/url_util.h"
 
 namespace local_discovery {

[Noam Samuel, 2013-09-06 22:03:58]

https://codereview.chromium.org/23508003/diff/1/tools/metrics/actions/extract...
File tools/metrics/actions/extract_actions.py (right):

https://codereview.chromium.org/23508003/diff/1/tools/metrics/actions/extract...
tools/metrics/actions/extract_actions.py:602: AddDevicesPageActions(actions)
On 2013/09/06 00:53:32, Ilya Sherman wrote:
> nit: While you're here, let's alphabetize these calls.

Done.

[commit-bot: I haz the power, 2013-09-06 22:23:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/23508003/18001

[commit-bot: I haz the power, 2013-09-06 22:23:44]

Failed to apply patch for
chrome/browser/resources/local_discovery/local_discovery.js:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/resources/local_discovery/local_discovery.js
  Hunk #1 FAILED at 86.
  Hunk #2 succeeded at 132 (offset -10 lines).
  Hunk #3 succeeded at 142 (offset -11 lines).
  Hunk #4 succeeded at 173 with fuzz 2 (offset -3 lines).
  Hunk #5 FAILED at 269.
  Hunk #6 FAILED at 306.
  Hunk #7 FAILED at 337.
  4 out of 7 hunks FAILED -- saving rejects to file
chrome/browser/resources/local_discovery/local_discovery.js.rej

Patch:       chrome/browser/resources/local_discovery/local_discovery.js
Index: chrome/browser/resources/local_discovery/local_discovery.js
diff --git a/chrome/browser/resources/local_discovery/local_discovery.js
b/chrome/browser/resources/local_discovery/local_discovery.js
index
6ff4865f9fffb2eb7274cbc37cbc6a892f14b774..1a6ade371dba2bef6d6cf19fffcefdf6dc0ca977
100644
--- a/chrome/browser/resources/local_discovery/local_discovery.js
+++ b/chrome/browser/resources/local_discovery/local_discovery.js
@@ -86,6 +86,7 @@ cr.define('local_discovery', function() {
      * Register the device.
      */
     register: function() {
+      recordUmaAction('DevicesPage_RegisterClicked');
       chrome.send('registerDevice', [this.info.service_name]);
       setRegisterPage('register-page-adding1');
     }
@@ -142,9 +143,10 @@ cr.define('local_discovery', function() {
   }
 
   /**
-   * Hide the register overlay.
+   * Show the register overlay.
    */
   function showRegisterOverlay() {
+    recordUmaAction('DevicesPage_AddPrintersClicked');
     $('register-overlay').classList.add('showing');
     $('overlay').hidden = false;
     uber.invokeMethodOnParent('beginInterceptingEvents');
@@ -152,13 +154,12 @@ cr.define('local_discovery', function() {
   }
 
   /**
-   * Show the register overlay.
+   * Hide the register overlay.
    */
   function hideRegisterOverlay() {
     $('register-overlay').classList.remove('showing');
     $('overlay').hidden = true;
     uber.invokeMethodOnParent('stopInterceptingEvents');
-    chrome.send('cancelRegistration');
   }
 
   /**
@@ -176,6 +177,7 @@ cr.define('local_discovery', function() {
    */
   function onRegistrationFailed() {
     setRegisterPage('register-page-error');
+    recordUmaAction('DevicesPage_RegisterFailure');
   }
 
   /**
@@ -268,6 +270,7 @@ cr.define('local_discovery', function() {
   function onRegistrationSuccess() {
     hideRegisterOverlay();
     requestPrinterList();
+    recordUmaAction('DevicesPage_RegisterSuccess');
   }
 
   /**
@@ -305,25 +308,42 @@ cr.define('local_discovery', function() {
    * @param {string} device_id ID of device.
    */
   function manageCloudDevice(device_id) {
+    recordUmaAction('DevicesPage_ManageClicked');
     chrome.send('openCloudPrintURL',
                 [PRINTER_MANAGEMENT_PAGE_PREFIX + device_id]);
   }
 
+  /**
+   * Record an action in UMA.
+   * @param {string} actionDesc The name of the action to be logged.
+   */
+  function recordUmaAction(actionDesc) {
+    chrome.send('metricsHandler:recordAction', [actionDesc]);
+  }
+
+  /**
+   * Cancel the registration.
+   */
+  function cancelRegistration() {
+    hideRegisterOverlay();
+    chrome.send('cancelRegistration');
+    recordUmaAction('DevicesPage_RegisterCancel');
+  }
 
   document.addEventListener('DOMContentLoaded', function() {
     uber.onContentFrameLoaded();
 
     cr.ui.overlay.setupOverlay($('overlay'));
     cr.ui.overlay.globalInitialization();
-    $('overlay').addEventListener('cancelOverlay', hideRegisterOverlay);
+    $('overlay').addEventListener('cancelOverlay', cancelRegistration);
 
     var cancelButtons = document.querySelectorAll('.register-cancel');
     var cancelButtonsLength = cancelButtons.length;
     for (var i = 0; i < cancelButtonsLength; i++) {
-      cancelButtons[i].addEventListener('click', hideRegisterOverlay);
+      cancelButtons[i].addEventListener('click', cancelRegistration);
     }
 
-    $('register-error-exit').addEventListener('click', hideRegisterOverlay);
+    $('register-error-exit').addEventListener('click', cancelRegistration);
 
     $('add-printers-button').addEventListener('click',
                                               showRegisterOverlay);
@@ -336,6 +356,7 @@ cr.define('local_discovery', function() {
     uber.invokeMethodOnParent('setTitle', {title: title});
 
     chrome.send('start');
+    recordUmaAction('DevicesPage_Opened');
     requestPrinterList();
   });

[commit-bot: I haz the power, 2013-09-07 04:52:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/noamsml@chromium.org/23508003/18001

[commit-bot: I haz the power, 2013-09-07 07:33:24]

Change committed as 221913