Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Issue 2350793002: LogDog: Use gRPC credential directly. (Closed)

Created:
4 years, 3 months ago by dnj
Modified:
4 years, 3 months ago
Reviewers:
Vadim Sh.
CC:
chromium-reviews, infra-reviews+luci-go_chromium.org, andrew.wang, todd, tandrii+luci-go_chromium.org, M-A Ruel
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

LogDog: Use gRPC credential directly. Previously, LogDog used an HTTP client with a token source to connect to BigTable, which uses gRPC. This broke at some point and now returns an error. Replace this with the proper direct gRPC credentials. TBR=vadimsh@chromium.org BUG=chromium:648278 - Deployed on production system, no longer encounters HTTP error and can successfully pull from BigTable. Committed: https://github.com/luci/luci-go/commit/e6e5673e8aa0a8e930ac3fcd693e671a6f8a71c1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M logdog/appengine/coordinator/service.go View 3 chunks +5 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
dnj
4 years, 3 months ago (2016-09-19 16:21:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350793002/1
4 years, 3 months ago (2016-09-19 16:21:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350793002/1
4 years, 3 months ago (2016-09-19 16:22:23 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://github.com/luci/luci-go/commit/e6e5673e8aa0a8e930ac3fcd693e671a6f8a71c1
4 years, 3 months ago (2016-09-19 16:31:26 UTC) #9
Vadim Sh.
lgtm I wonder why it broke...
4 years, 3 months ago (2016-09-19 18:00:22 UTC) #10
dnj
4 years, 3 months ago (2016-09-19 18:10:32 UTC) #11
Message was sent while issue was closed.
On 2016/09/19 18:00:22, Vadim Sh. wrote:
> lgtm
> 
> I wonder why it broke...

I haven't deployed in the last 1.5 months, so probably BigTable or Google Client
API update disallowed direct HTTP client supplying.

Powered by Google App Engine
This is Rietveld 408576698