Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(507)

Issue 2350773003: Plugin Power Saver: Fix browsertest in official builds. (Closed)

Created:
4 years, 3 months ago by tommycli
Modified:
4 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, jam
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Plugin Power Saver: Fix browsertest in official builds. Official builds don't use the Field Trial config JSON files, so this CL manually adds the feature flags in the setup portion of the test. BUG=648254 Committed: https://crrev.com/b6aa0954dca4bc6eba852b15be7187707fbe56ed Cr-Commit-Position: refs/heads/master@{#419611}

Patch Set 1 #

Total comments: 2

Patch Set 2 : add comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 1 2 chunks +9 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
tommycli
thakis: PTAL, thanks!
4 years, 3 months ago (2016-09-19 22:41:02 UTC) #2
Nico
rs-lgtm https://codereview.chromium.org/2350773003/diff/1/chrome/browser/plugins/plugin_power_saver_browsertest.cc File chrome/browser/plugins/plugin_power_saver_browsertest.cc (right): https://codereview.chromium.org/2350773003/diff/1/chrome/browser/plugins/plugin_power_saver_browsertest.cc#newcode293 chrome/browser/plugins/plugin_power_saver_browsertest.cc:293: feature_list.InitAndEnableFeature(features::kBlockSmallContent); maybe add a comment for why this ...
4 years, 3 months ago (2016-09-19 22:44:42 UTC) #3
tommycli
thanks! https://codereview.chromium.org/2350773003/diff/1/chrome/browser/plugins/plugin_power_saver_browsertest.cc File chrome/browser/plugins/plugin_power_saver_browsertest.cc (right): https://codereview.chromium.org/2350773003/diff/1/chrome/browser/plugins/plugin_power_saver_browsertest.cc#newcode293 chrome/browser/plugins/plugin_power_saver_browsertest.cc:293: feature_list.InitAndEnableFeature(features::kBlockSmallContent); On 2016/09/19 22:44:42, Nico wrote: > maybe ...
4 years, 3 months ago (2016-09-19 23:10:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350773003/20001
4 years, 3 months ago (2016-09-19 23:10:30 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 00:43:01 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 00:45:14 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b6aa0954dca4bc6eba852b15be7187707fbe56ed
Cr-Commit-Position: refs/heads/master@{#419611}

Powered by Google App Engine
This is Rietveld 408576698