[Extensions] Fix a bug in the startup pages override bubble

[Extensions] Fix a bug in the startup pages override bubble

We show the startup pages override bubble on the first start of chrome
after the user installs an extension overriding the startup pages.
However, if the user happened to restart chrome (e.g. through
chrome://restart), then the pages shown won't be the startup pages.
Check for this before showing the bubble, and add a regression test.

BUG=649001
Committed: https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32
Cr-Commit-Position: refs/heads/master@{#420115}

[Devlin, 2016-09-20 22:00:24]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 22:01:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-20 22:52:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-20 22:52:32]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Devlin, 2016-09-20 23:12:17]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-20 23:12:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 00:17:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 00:17:51]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Devlin, 2016-09-21 00:31:25]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 00:33:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Devlin, 2016-09-21 01:03:50]

Description was changed from

==========
Add test
BUG=
==========

to

==========
[Extensions] Fix a bug in the startup pages override bubble

We show the startup pages override bubble on the first start of chrome
after the user installs an extension overriding the startup pages.
However, if the user happened to restart chrome (e.g. through
chrome://restart), then the pages shown won't be the startup pages.
Check for this before showing the bubble, and add a regression test.

BUG=
==========

[Devlin, 2016-09-21 01:03:56]

Patchset #1 (id:1) has been deleted

[Devlin, 2016-09-21 01:04:01]

Patchset #1 (id:20001) has been deleted

[Devlin, 2016-09-21 01:04:08]

Patchset #1 (id:40001) has been deleted

[Devlin, 2016-09-21 01:50:57]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2016-09-21 01:50:58]

Finnur, can you take a look? (I'll be sure to add a BUG= tomotrow.)

https://codereview.chromium.org/2350733005/diff/60001/chrome/browser/ui/exten...
File chrome/browser/ui/extensions/extension_message_bubble_factory.cc (right):

https://codereview.chromium.org/2350733005/diff/60001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/extension_message_bubble_factory.cc:12: #include
"chrome/browser/browser_process.h"
Whoops - will clean up these includes

[commit-bot: I haz the power, 2016-09-21 02:52:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 02:52:43]

Dry run: This issue passed the CQ dry run.

[Finnur, 2016-09-21 10:05:10]

LGTM.

https://codereview.chromium.org/2350733005/diff/60001/chrome/browser/ui/exten...
File chrome/browser/ui/extensions/extension_message_bubble_factory.cc (right):

https://codereview.chromium.org/2350733005/diff/60001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/extension_message_bubble_factory.cc:12: #include
"chrome/browser/browser_process.h"
OK. 

Remember the BUG= also.

[Devlin, 2016-09-21 16:29:31]

Description was changed from

==========
[Extensions] Fix a bug in the startup pages override bubble

We show the startup pages override bubble on the first start of chrome
after the user installs an extension overriding the startup pages.
However, if the user happened to restart chrome (e.g. through
chrome://restart), then the pages shown won't be the startup pages.
Check for this before showing the bubble, and add a regression test.

BUG=
==========

to

==========
[Extensions] Fix a bug in the startup pages override bubble

We show the startup pages override bubble on the first start of chrome
after the user installs an extension overriding the startup pages.
However, if the user happened to restart chrome (e.g. through
chrome://restart), then the pages shown won't be the startup pages.
Check for this before showing the bubble, and add a regression test.

BUG=649001
==========

[Devlin, 2016-09-21 17:07:31]

https://codereview.chromium.org/2350733005/diff/60001/chrome/browser/ui/exten...
File chrome/browser/ui/extensions/extension_message_bubble_factory.cc (right):

https://codereview.chromium.org/2350733005/diff/60001/chrome/browser/ui/exten...
chrome/browser/ui/extensions/extension_message_bubble_factory.cc:12: #include
"chrome/browser/browser_process.h"
On 2016/09/21 10:05:10, Finnur wrote:
> OK. 
> 
> Remember the BUG= also.

Done and done. :)

[Devlin, 2016-09-21 17:07:47]

rdevlin.cronin@chromium.org changed reviewers:
+ avi@chromium.org

[Devlin, 2016-09-21 17:07:48]

+Avi for the small Cocoa change.

[Avi (use Gerrit), 2016-09-21 17:32:54]

chrome/browser/ui/cocoa/extensions/extension_message_bubble_browsertest_mac.mm
lgtm

[Devlin, 2016-09-21 17:33:08]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2016-09-21 17:33:08]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/2350733005/#ps80001
(title: "Trim includes")

[commit-bot: I haz the power, 2016-09-21 17:34:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 18:41:57]

Description was changed from

==========
[Extensions] Fix a bug in the startup pages override bubble

We show the startup pages override bubble on the first start of chrome
after the user installs an extension overriding the startup pages.
However, if the user happened to restart chrome (e.g. through
chrome://restart), then the pages shown won't be the startup pages.
Check for this before showing the bubble, and add a regression test.

BUG=649001
==========

to

==========
[Extensions] Fix a bug in the startup pages override bubble

We show the startup pages override bubble on the first start of chrome
after the user installs an extension overriding the startup pages.
However, if the user happened to restart chrome (e.g. through
chrome://restart), then the pages shown won't be the startup pages.
Check for this before showing the bubble, and add a regression test.

BUG=649001
==========

[commit-bot: I haz the power, 2016-09-21 18:41:58]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-09-21 18:44:00]

Description was changed from

==========
[Extensions] Fix a bug in the startup pages override bubble

We show the startup pages override bubble on the first start of chrome
after the user installs an extension overriding the startup pages.
However, if the user happened to restart chrome (e.g. through
chrome://restart), then the pages shown won't be the startup pages.
Check for this before showing the bubble, and add a regression test.

BUG=649001
==========

to

==========
[Extensions] Fix a bug in the startup pages override bubble

We show the startup pages override bubble on the first start of chrome
after the user installs an extension overriding the startup pages.
However, if the user happened to restart chrome (e.g. through
chrome://restart), then the pages shown won't be the startup pages.
Check for this before showing the bubble, and add a regression test.

BUG=649001

Committed: https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32
Cr-Commit-Position: refs/heads/master@{#420115}
==========

[commit-bot: I haz the power, 2016-09-21 18:44:01]

Patchset 2 (id:??) landed as
https://crrev.com/d9a05aa24453233fa8cd375a5d9fff11de8a7c32
Cr-Commit-Position: refs/heads/master@{#420115}