Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 2350733002: Revert of Add tests for trace wrappers (Closed)

Created:
4 years, 3 months ago by iclelland
Modified:
4 years, 3 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, chromium-reviews, Hannes Payer (out of office), Michael Lippautz
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add tests for trace wrappers (patchset #15 id:280001 of https://codereview.chromium.org/2301213003/ ) Reason for revert: Sorry for the revert; this patch has (I believe) caused the heap-snapshot-with-detached-dom-tree.html to start failing. The very first failure in that test was in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/17518 -- immediately after this CL was committed. Here is the flakiness dashboard result for that test: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fheap-profiler%2Fheap-snapshot-with-detached-dom-tree.html&testType=webkit_tests The test is failing occasionally with output like this: Test that all nodes from the detached DOM tree will get into one group in the heap snapshot. Bug 107819. Took heap snapshot Parsed snapshot SUCCESS: found (Detached DOM trees) SUCCESS: found Detached DOM tree / 3 entries FAIL: unexpected DIV count: 1 Reverting this CL since it appears to be primarily about the tests. Original issue's description: > Add tests for trace wrappers > > This cl adds very basic tests for general trace wrappers features. And enables TraceWrappables runtime enabled feature for tests! > > LOG=no > BUG=468240 > > Committed: https://crrev.com/f7d5d042289c5fbe918348830917b888ec587272 > Cr-Commit-Position: refs/heads/master@{#419298} TBR=haraken@chromium.org,mlippautz@chromium.org,hlopko@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=468240 Committed: https://crrev.com/6e1cdbd8349e1e44b1f99af8b981d8f63f39b21d Cr-Commit-Position: refs/heads/master@{#419463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -249 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/NodeList/nodelist-reachable-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-active-dom-object-expected.txt View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-detached-dom-tree-expected.txt View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector-protocol/heap-profiler/heap-snapshot-with-event-listener-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/bindings.gni View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitor.h View 3 chunks +11 lines, -21 lines 0 comments Download
D third_party/WebKit/Source/bindings/core/v8/ScriptWrappableVisitorTest.cpp View 1 chunk +0 lines, -147 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8GCController.cpp View 1 chunk +2 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/BUILD.gn View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/core_idl_files.gni View 1 chunk +0 lines, -1 line 0 comments Download
D third_party/WebKit/Source/core/testing/DeathAwareScriptWrappable.h View 1 chunk +0 lines, -46 lines 0 comments Download
D third_party/WebKit/Source/core/testing/DeathAwareScriptWrappable.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/Source/core/testing/DeathAwareScriptWrappable.idl View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
iclelland
Created Revert of Add tests for trace wrappers
4 years, 3 months ago (2016-09-19 13:35:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350733002/1
4 years, 3 months ago (2016-09-19 13:35:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-19 15:24:15 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6e1cdbd8349e1e44b1f99af8b981d8f63f39b21d Cr-Commit-Position: refs/heads/master@{#419463}
4 years, 3 months ago (2016-09-19 15:26:36 UTC) #7
haraken
4 years, 3 months ago (2016-09-20 00:43:24 UTC) #8
Message was sent while issue was closed.
LGTM to revert

Powered by Google App Engine
This is Rietveld 408576698