DescriptionRevert of Add tests for trace wrappers (patchset #15 id:280001 of https://codereview.chromium.org/2301213003/ )
Reason for revert:
Sorry for the revert; this patch has (I believe) caused the heap-snapshot-with-detached-dom-tree.html to start failing.
The very first failure in that test was in https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/17518 -- immediately after this CL was committed.
Here is the flakiness dashboard result for that test:
https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=inspector-protocol%2Fheap-profiler%2Fheap-snapshot-with-detached-dom-tree.html&testType=webkit_tests
The test is failing occasionally with output like this:
Test that all nodes from the detached DOM tree will get into one group in the heap snapshot. Bug 107819.
Took heap snapshot
Parsed snapshot
SUCCESS: found (Detached DOM trees)
SUCCESS: found Detached DOM tree / 3 entries
FAIL: unexpected DIV count: 1
Reverting this CL since it appears to be primarily about the tests.
Original issue's description:
> Add tests for trace wrappers
>
> This cl adds very basic tests for general trace wrappers features. And enables TraceWrappables runtime enabled feature for tests!
>
> LOG=no
> BUG=468240
>
> Committed: https://crrev.com/f7d5d042289c5fbe918348830917b888ec587272
> Cr-Commit-Position: refs/heads/master@{#419298}
TBR=haraken@chromium.org,mlippautz@chromium.org,hlopko@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=468240
Committed: https://crrev.com/6e1cdbd8349e1e44b1f99af8b981d8f63f39b21d
Cr-Commit-Position: refs/heads/master@{#419463}
Patch Set 1 #Messages
Total messages: 8 (3 generated)
|