Issue 23507002: Revert 156733 "Refactoring DrawLooper so that it can apply shado..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23507002: Revert 156733 "Refactoring DrawLooper so that it can apply shado..." (Closed)

Created:
7 years, 3 months ago by jianli

Modified:
7 years, 3 months ago

Reviewers:
Justin Novosad

CC:
blink-reviews

Base URL:
svn://svn.chromium.org/blink/

Visibility:
Public.

More Reviews

Description

Revert 156733 "Refactoring DrawLooper so that it can apply shado..." > Refactoring DrawLooper so that it can apply shadow effects as skia image filters > > This fixes a bug where a bitmap's alpha channel was not being blurred when > rendering 2D canvas shadows. > > BUG=100703 > R=senorblanco > TEST=LayoutTest fast/canvas/canvas-drawImage-shadow-blur.html > > Review URL: https://chromiumcodereview.appspot.com/23102018 TBR=junov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=156738

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+75 lines, -220 lines)			Patch
M	trunk/LayoutTests/TestExpectations	View	1 chunk	+0 lines, -4 lines	0 comments	Download
MM	trunk/LayoutTests/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt	View	1 chunk	+12 lines, -12 lines	0 comments	Download
MM	trunk/LayoutTests/fast/canvas/canvas-drawImage-shadow-expected.txt	View	1 chunk	+0 lines, -4 lines	0 comments	Download
MM	trunk/LayoutTests/fast/canvas/script-tests/canvas-draw-canvas-on-canvas-shadow.js	View	1 chunk	+1 line, -1 line	0 comments	Download
MM	trunk/LayoutTests/fast/canvas/script-tests/canvas-drawImage-shadow.js	View	1 chunk	+0 lines, -7 lines	0 comments	Download
A +	trunk/LayoutTests/platform/mac/virtual/gpu/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	trunk/Source/core/platform/graphics/DrawLooper.h	View	2 chunks	+5 lines, -34 lines	0 comments	Download
M	trunk/Source/core/platform/graphics/DrawLooper.cpp	View	2 chunks	+30 lines, -123 lines	0 comments	Download
M	trunk/Source/core/platform/graphics/GraphicsContext.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	trunk/Source/core/platform/graphics/GraphicsContext.cpp	View	3 chunks	+9 lines, -9 lines	0 comments	Download
M	trunk/Source/core/platform/graphics/GraphicsContextState.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	trunk/Source/core/platform/graphics/skia/NativeImageSkia.cpp	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	trunk/Source/core/rendering/EllipsisBox.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	trunk/Source/core/rendering/InlineTextBox.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	trunk/Source/core/rendering/RenderBoxModelObject.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	trunk/Source/core/rendering/svg/SVGInlineTextBox.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r156738.

Expand Messages | Collapse Messages