Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(824)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/public/common/media_stream_request.h

Issue 2350693002: Remove device enumeration, caching and monitoring from MediaStreamManager. (Closed)
Patch Set: Minor DCHECK fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/renderer_host/media/video_capture_manager_unittest.cc ('K') | « content/common/media/media_devices.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/media_stream_request.h
diff --git a/content/public/common/media_stream_request.h b/content/public/common/media_stream_request.h
index 55171ab9489b3ffccaf6121e32799514e34985a0..71188adde5ccb7038d26f07f5b43f25b23967b66 100644
--- a/content/public/common/media_stream_request.h
+++ b/content/public/common/media_stream_request.h
@@ -38,9 +38,9 @@ enum MediaStreamType {
// Capture system audio (post-mix loopback stream).
MEDIA_DESKTOP_AUDIO_CAPTURE,
- // This is used for enumerating audio output devices.
- // TODO(grunell): Output isn't really a part of media streams. Device
- // enumeration should be decoupled from media streams and related code.
+ // TODO(guidou): This is used for device enumerations, but it is not a
+ // media stream type. Remove when handling of renderer-generated enumeration
+ // requests is removed from MediaStreamManager. See http://crbug.com/648183.
MEDIA_DEVICE_AUDIO_OUTPUT,
NUM_MEDIA_TYPES
« content/browser/renderer_host/media/video_capture_manager_unittest.cc ('K') | « content/common/media/media_devices.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698