Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 2350683002: Add a missing test for ensuring that context shapes stay the same when recompiling. (Closed)

Created:
4 years, 3 months ago by marja
Modified:
4 years, 3 months ago
Reviewers:
Michael Starzinger
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add a missing test for ensuring that context shapes stay the same when recompiling. This would've caught the "preparser tracking only unresolved variables but no declarations is not enough" bug. BUG= Committed: https://crrev.com/df9d8c01f29ec50cbc792d8d6ecda3d5722c1a59 Cr-Commit-Position: refs/heads/master@{#39532}

Patch Set 1 #

Patch Set 2 : updated to use native syntax #

Unified diffs Side-by-side diffs Delta from patch set Stats (+253 lines, -0 lines) Patch
A test/mjsunit/fixed-context-shapes-when-recompiling.js View 1 1 chunk +253 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
marja
mstarzinger@, ptal
4 years, 3 months ago (2016-09-19 12:20:47 UTC) #2
Michael Starzinger
LGTM.
4 years, 3 months ago (2016-09-20 09:06:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350683002/20001
4 years, 3 months ago (2016-09-20 09:07:35 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-20 09:35:23 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-09-20 09:35:48 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/df9d8c01f29ec50cbc792d8d6ecda3d5722c1a59
Cr-Commit-Position: refs/heads/master@{#39532}

Powered by Google App Engine
This is Rietveld 408576698