Get rid of code duplication in LinkRelAttribute

Get rid of code duplication in LinkRelAttribute

There was a "fast path" that just compared the strings and then another
that split and then compared. The two paths were slightly different for
no obvious reasons which doesn't really follow the spec where the tokens
can be all mixed with each other (except for "shortcut icon" apparently).

Allocating the separate strings for "alternate stylesheet" should not be
an issue.

I also removed the extra constructor, we can just use a default argument
value.

The only behavior change is that now we allow things like "alternate import"
(or dns-prefetch) and just ignore the alternate part when deciding what
to do with the link.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171380

[abarth-chromium, 2014-04-11 18:30:03]

lgtm

[commit-bot: I haz the power, 2014-04-11 18:30:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/235063003/1

[commit-bot: I haz the power, 2014-04-11 18:59:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 18:59:10]

Try jobs failed on following builders:
  tryserver.blink on blink_presubmit

[esprehn, 2014-04-11 19:16:59]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-04-11 19:17:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/235063003/1

[commit-bot: I haz the power, 2014-04-11 19:17:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 19:17:34]

Try jobs failed on following builders:
  tryserver.blink on linux_blink_rel

[esprehn, 2014-04-11 19:19:31]

On 2014/04/11 19:17:34, I haz the power (commit-bot) wrote:
> Try jobs failed on following builders:
>   tryserver.blink on linux_blink_rel

Alas, you can't use String::split with inline capacity :/ I don't think it will
matter for this though.

[esprehn, 2014-04-11 19:19:45]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-04-11 19:19:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/235063003/20001

[commit-bot: I haz the power, 2014-04-11 19:32:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 19:32:08]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[esprehn, 2014-04-11 20:25:59]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-04-11 20:26:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/235063003/40001

[commit-bot: I haz the power, 2014-04-11 20:38:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 20:38:50]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[esprehn, 2014-04-11 20:52:18]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-04-11 20:52:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/235063003/60001

[commit-bot: I haz the power, 2014-04-11 21:03:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 21:03:48]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[esprehn, 2014-04-11 21:07:55]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-04-11 21:08:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/235063003/80001

[commit-bot: I haz the power, 2014-04-11 21:41:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-11 21:41:27]

Try jobs failed on following builders:
  tryserver.blink on mac_blink_rel

[esprehn, 2014-04-11 23:37:39]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2014-04-11 23:37:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/esprehn@chromium.org/235063003/80001

[commit-bot: I haz the power, 2014-04-12 00:08:17]

Change committed as 171380