Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 2350613002: add 'g' to fatbits (Closed)

Created:
4 years, 3 months ago by reed1
Modified:
4 years, 3 months ago
Reviewers:
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove dead gpu option #

Patch Set 3 : fZoom needs to be int #

Patch Set 4 : dang I wish I saw these warnings on mac #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -64 lines) Patch
M samplecode/SampleFatBits.cpp View 1 2 3 9 chunks +36 lines, -64 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350613002/20001
4 years, 3 months ago (2016-09-19 00:50:21 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Release-Vulkan-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Release-Vulkan-Trybot/builds/1730)
4 years, 3 months ago (2016-09-19 00:59:22 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350613002/40001
4 years, 3 months ago (2016-09-19 12:53:01 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Release-Vulkan-Trybot on master.client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Release-Vulkan-Trybot/builds/1734)
4 years, 3 months ago (2016-09-19 13:10:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2350613002/60001
4 years, 3 months ago (2016-09-19 13:13:26 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-19 14:10:38 UTC) #17
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/8716a8ae94b55d062c6600a006310a0be67788a8

Powered by Google App Engine
This is Rietveld 408576698