Issue 23506038: Add options to disable each of the two aspects of the prerender service

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23506038: Add options to disable each of the two aspects of the prerender service (Closed)

Created:
7 years, 3 months ago by tburkard

Modified:
7 years, 3 months ago

Reviewers:
jam

CC:
chromium-reviews, tburkard+watch_chromium.org, gavinp+prer_chromium.org, cbentzel+watch_chromium.org, dominich+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Add options to disable each of the two aspects of the prerender service (current URL based hinting and candidate URL upload). R=jam@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222082

Patch Set 1 #

Total comments: 2

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+70 lines, -40 lines)			Patch
M	chrome/browser/prerender/prerender_field_trial.h	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/prerender/prerender_field_trial.cc	View	2 chunks	+14 lines, -0 lines	0 comments	Download
M	chrome/browser/prerender/prerender_local_predictor.cc	View	4 chunks	+51 lines, -40 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

jam

lgtm https://codereview.chromium.org/23506038/diff/1/chrome/browser/prerender/prerender_local_predictor.cc File chrome/browser/prerender/prerender_local_predictor.cc (right): https://codereview.chromium.org/23506038/diff/1/chrome/browser/prerender/prerender_local_predictor.cc#newcode763 chrome/browser/prerender/prerender_local_predictor.cc:763: for (int i = 0; i < static_cast<int>(info->candidate_urls_.size()); ...

7 years, 3 months ago (2013-09-09 20:22:51 UTC) #2

tburkard

7 years, 3 months ago (2013-09-09 20:29:38 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r222082 (presubmit successful).

Expand Messages | Collapse Messages